Bug 90013

Summary: [Chromium] Decrease the number of conditional blocks in features.gypi
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89944    
Attachments:
Description Flags
Patch none

Peter Beverloo
Reported 2012-06-26 14:15:30 PDT
[Chromium] Decrease the number of conditional blocks in features.gypi
Attachments
Patch (2.54 KB, patch)
2012-06-26 14:20 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-06-26 14:20:45 PDT
Created attachment 149606 [details] Patch
Peter Beverloo
Comment 2 2012-06-26 14:27:22 PDT
While it's not strictly blocking 89944, labeling it as such so it's clear where this comes from. I also added a comment to the conditional since the differences between Android and non-Android are still rather big :(.
WebKit Review Bot
Comment 3 2012-06-26 17:06:35 PDT
Comment on attachment 149606 [details] Patch Clearing flags on attachment: 149606 Committed r121304: <http://trac.webkit.org/changeset/121304>
WebKit Review Bot
Comment 4 2012-06-26 17:06:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.