Bug 90013 - [Chromium] Decrease the number of conditional blocks in features.gypi
Summary: [Chromium] Decrease the number of conditional blocks in features.gypi
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks: 89944
  Show dependency tree / graph
 
Reported: 2012-06-26 14:15 PDT by Peter Beverloo
Modified: 2012-06-26 17:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2012-06-26 14:20 PDT, Peter Beverloo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-06-26 14:15:30 PDT 
[Chromium] Decrease the number of conditional blocks in features.gypi
Comment 1 Peter Beverloo 2012-06-26 14:20:45 PDT 
Created attachment 149606 [details]
Patch
Comment 2 Peter Beverloo 2012-06-26 14:27:22 PDT 
While it's not strictly blocking 89944, labeling it as such so it's clear where this comes from. I also added a comment to the conditional since the differences between Android and non-Android are still rather big :(.
Comment 3 WebKit Review Bot 2012-06-26 17:06:35 PDT 
Comment on attachment 149606 [details]
Patch

Clearing flags on attachment: 149606

Committed r121304: <http://trac.webkit.org/changeset/121304>
Comment 4 WebKit Review Bot 2012-06-26 17:06:41 PDT 
All reviewed patches have been landed.  Closing bug.