Bug 90010

Summary: Fix platform picker change handler in garden-o-matic
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+, simon.fraser: commit-queue+

Ojan Vafai
Reported 2012-06-26 13:44:51 PDT
Fix platform picker change handler in garden-o-matic
Attachments
Patch (2.63 KB, patch)
2012-06-26 13:57 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (2.63 KB, patch)
2012-06-26 13:58 PDT, Ojan Vafai 		simon.fraser: review+
simon.fraser: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-06-26 13:57:37 PDT
Created attachment 149601 [details] Patch
Ojan Vafai
Comment 2 2012-06-26 13:58:05 PDT
Created attachment 149602 [details] Patch
Simon Fraser (smfr)
Comment 3 2012-06-26 14:04:33 PDT
Comment on attachment 149602 [details] Patch Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac.
Adam Barth
Comment 4 2012-06-26 14:08:48 PDT
> Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac. Presumably you want to be able to select things other than the zeroth option, right?
Simon Fraser (smfr)
Comment 5 2012-06-26 14:12:17 PDT
(In reply to comment #4) > > Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac. > > Presumably you want to be able to select things other than the zeroth option, right? No, selectedOptions is a collection of the options that are selected (in the case of a dropdown, just the checked one).
Adam Barth
Comment 6 2012-06-26 14:14:48 PDT
> No, selectedOptions is a collection of the options that are selected (in the case of a dropdown, just the checked one). Ah, I misread the diff.
Simon Fraser (smfr)
Comment 7 2012-06-26 14:15:34 PDT
Comment on attachment 149602 [details] Patch OK, now we understand that selectedOptions was rolled out via bug 88749.
Ojan Vafai
Comment 8 2012-06-26 14:22:16 PDT
Committed r121287: <http://trac.webkit.org/changeset/121287>
Note You need to log in before you can comment on or make changes to this bug.