Summary: | [GTK] MHTML files not being loaded due to reported mime type not supported | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, japhet, jcivelli, jochen, mrobinson, svillar, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 89987 | ||||||
Attachments: |
|
Description
Mario Sanchez Prada
2012-06-26 06:56:36 PDT
Created attachment 149543 [details]
Patch proposal
Attaching patch that adds 'message/rfc822' to the list of supported MIME types when MHTML is enabled.
The tests for this changeset is the fact that we add new expectations to platform/gtk/mhtml, that will be taken into consideration as soon as we enable MHTML by default at build time (bug+patch coming soon)
As the author of the the commit adding MHTML read support in WebCore [1], I'm adding Jay Civelli to CC. He could probably be interested in providing feedback about to the following doubts I still have: - Do you agree with this bug and with the proposed solution? (at the moment the current patch is meant to affect GTK only) - As test expectations are identical for GTK than for chromium, would you agree with moving them out from platform/chromium/mhtml to mhtml/? Or would it be better to introduce new expectations files for GTK (even if they are identical) under platform/gtk/mhtml? About the second one, I think it would be better to share expectations (thus moving to mhtml/). After all, platforms building without the MHTML feature enabled will skip that directory when running the tests. [1] http://trac.webkit.org/changeset/87189 Ping reviewers? Comment on attachment 149543 [details]
Patch proposal
I guess we can land this patch for now, and simply move the test expectation later if chromium guys agree on it.
Sorry for the late reply. I am OK with adding message/rfc822 as a MHTML mime-type. For the test expectations, yes, we should share them. Feel free to make that in a subsequent patch. Thanks. (In reply to comment #5) > Sorry for the late reply. > I am OK with adding message/rfc822 as a MHTML mime-type. > > For the test expectations, yes, we should share them. > Feel free to make that in a subsequent patch. Great. Now I need to leave but I will take care of updating the patch tomorrow already. Thanks for the review. Committed r123088: <http://trac.webkit.org/changeset/123088> |