| Summary: | Web Inspector: Add DirectoryContentView for FileSystemView | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Taiju Tsuiki <tzik> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Taiju Tsuiki <tzik> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | 73301, 87856 | ||||||||||||
| Bug Blocks: | 68203, 90361 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 149489 [details]
Patch
Comment on attachment 149489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149489&action=review > Source/WebCore/inspector/front-end/DirectoryContentView.js:60 > +WebInspector.DirectoryContentView.columnIndices = { We prefer indexes in inspector code. > Source/WebCore/inspector/front-end/DirectoryContentView.js:61 > + NAME: 0, Name > Source/WebCore/inspector/front-end/DirectoryContentView.js:63 > + TYPE: 2, Type > Source/WebCore/inspector/front-end/DirectoryContentView.js:64 > + SIZE: 3, Size > Source/WebCore/inspector/front-end/DirectoryContentView.js:65 > + MTIME: 4 ModificationTime > Source/WebCore/inspector/front-end/DirectoryContentView.js:100 > + if ("size" in metadata) Isn't size always available? > Source/WebCore/inspector/front-end/FileSystemView.js:98 > + } else { else return Created attachment 150357 [details]
Patch
Comment on attachment 149489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149489&action=review >> Source/WebCore/inspector/front-end/DirectoryContentView.js:60 >> +WebInspector.DirectoryContentView.columnIndices = { > > We prefer indexes in inspector code. Done >> Source/WebCore/inspector/front-end/DirectoryContentView.js:61 >> + NAME: 0, > > Name Done >> Source/WebCore/inspector/front-end/DirectoryContentView.js:63 >> + TYPE: 2, > > Type Done >> Source/WebCore/inspector/front-end/DirectoryContentView.js:64 >> + SIZE: 3, > > Size Done >> Source/WebCore/inspector/front-end/DirectoryContentView.js:65 >> + MTIME: 4 > > ModificationTime Done >> Source/WebCore/inspector/front-end/DirectoryContentView.js:100 >> + if ("size" in metadata) > > Isn't size always available? No, it's not available for directories. >> Source/WebCore/inspector/front-end/FileSystemView.js:98 >> + } else { > > else > return Done Created attachment 150366 [details]
Patch
Comment on attachment 150366 [details] Patch Clearing flags on attachment: 150366 Committed r121671: <http://trac.webkit.org/changeset/121671> All reviewed patches have been landed. Closing bug. |
Created attachment 149487 [details] Screenshot After FileSystemView landed, I'd like to add a view to show details of directory contents. This patch adds DirectoryContentView based on DataGrid, showing name, URL, type and modification time.