Bug 89959

Summary: Change return type in bandwidth attribute of network information API
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cdumez, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89870    
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-06-26 01:57:02 PDT
According to network information API spec, bandwidth attribute should return double type. But, existing implementation has used *long* and *unsigned int* types.
Attachments
Patch (10.03 KB, patch)
2012-06-26 02:00 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (9.94 KB, patch)
2012-06-26 17:04 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-06-26 02:00:23 PDT
Created attachment 149486 [details] Patch
Gyuyoung Kim
Comment 2 2012-06-26 02:10:48 PDT
CC'ing Adam.
Chris Dumez
Comment 3 2012-06-26 04:13:46 PDT
Comment on attachment 149486 [details] Patch LGTM.
Adam Barth
Comment 4 2012-06-26 11:05:45 PDT
Comment on attachment 149486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149486&action=review > Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp:95 > - return bandwidth / 8; // MB/s > + return static_cast<double>(bandwidth / 8); // MB/s This static_cast shouldn't be needed.
Gyuyoung Kim
Comment 5 2012-06-26 17:04:15 PDT
Created attachment 149637 [details] Patch
Gyuyoung Kim
Comment 6 2012-06-26 17:05:31 PDT
(In reply to comment #4) > (From update of attachment 149486 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=149486&action=review > > > Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp:95 > > - return bandwidth / 8; // MB/s > > + return static_cast<double>(bandwidth / 8); // MB/s > > This static_cast shouldn't be needed. I fix it. Thanks.
WebKit Review Bot
Comment 7 2012-06-26 19:11:31 PDT
Comment on attachment 149637 [details] Patch Clearing flags on attachment: 149637 Committed r121312: <http://trac.webkit.org/changeset/121312>
WebKit Review Bot
Comment 8 2012-06-26 19:11:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.