Bug 89944 – Enables <input type="color"> for ChromeOS

• Component: Forms
• Status: RESOLVED FIXED

[Jun Mukai]

http://crrev.com/144111 added the UI of <input type="color"> for ChromeOS, so now we can set ENABLE_INPUT_TYPE_COLOR for ChromeOS too.

[Jun Mukai]

Created attachment 149460 [details]
Patch

[Kent Tamura]

Comment on attachment 149460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149460&action=review

> Source/WebKit/chromium/features.gypi:177
> -      ['OS=="android" or chromeos==1', {
> +      ['OS=="android"', {

Did you confirm the following steps?
 1. build with unmodified features.gypi
 2. Modify features.gypi, and run gyp
 3. build again
 4. the build succeeds

I'm afraid this change requires clobber build for every ChromeOS developers.

[Jun Mukai]

I've done what you pointed during my development actually, but repeated just in case, and successfully built the binary with the color chooser UI in step 4.  gyp_chromium and make/ninja catch the change and rebuilt the whole WebKit in step 3.

[Kent Tamura]

Ok, thanks!

[WebKit Review Bot]

Comment on attachment 149460 [details]
Patch

Clearing flags on attachment: 149460

Committed r121237: <http://trac.webkit.org/changeset/121237>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Peter Beverloo]

Comment on attachment 149460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149460&action=review

>> Source/WebKit/chromium/features.gypi:177
>> +      ['OS=="android"', {
> 
> Did you confirm the following steps?
>  1. build with unmodified features.gypi
>  2. Modify features.gypi, and run gyp
>  3. build again
>  4. the build succeeds
> 
> I'm afraid this change requires clobber build for every ChromeOS developers.

This already landed, but a nit nonetheless: there is an OS==android section just above here, it'd have been better to consolidate this define in there. I'll upload a patch to do so.