Bug 89910

Summary: Fix the css stylesheet for android media controls after recent changes
Product: WebKit Reporter: Min Qin <qinmin>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric.carlson, feature-media-reviews, macpherson, menard, silviapf, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Min Qin
Reported 2012-06-25 14:24:46 PDT
Fix the css stylesheet for android media controls after recent changes
Attachments
Patch (8.05 KB, patch)
2012-06-25 14:31 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Min Qin
Comment 1 2012-06-25 14:31:25 PDT
Created attachment 149360 [details] Patch
Eric Carlson
Comment 2 2012-06-25 14:41:25 PDT
Comment on attachment 149360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149360&action=review > Source/WebCore/ChangeLog:10 > + No tests needed, just css changes. > + Changes to media controls CSS usually require new test results. Are there no layout tests for Chromium Android?
Min Qin
Comment 3 2012-06-25 14:45:46 PDT
There are currently no new layout tests for chrome on android in webkit. I will update the test expetations later when DumpRenderTree starts running on the bot.
WebKit Review Bot
Comment 4 2012-06-25 18:34:52 PDT
Comment on attachment 149360 [details] Patch Clearing flags on attachment: 149360 Committed r121210: <http://trac.webkit.org/changeset/121210>
WebKit Review Bot
Comment 5 2012-06-25 18:34:56 PDT
All reviewed patches have been landed. Closing bug.
Eric Carlson
Comment 6 2012-06-26 08:31:36 PDT
(In reply to comment #3) > There are currently no new layout tests for chrome on android in webkit. Then your comment in the ChangeLog, "No tests needed, just css changes", was incorrect.
Min Qin
Comment 7 2012-06-26 09:35:24 PDT
Yes, thanks for pointing out that. I should have put a comment there that chrome on android currently does not have layout test. (In reply to comment #6) > (In reply to comment #3) > > There are currently no new layout tests for chrome on android in webkit. > > Then your comment in the ChangeLog, "No tests needed, just css changes", was incorrect.
Note You need to log in before you can comment on or make changes to this bug.