Bug 89877

Summary: [EFL][WK2] Missing ViewIsFocused flag in viewStateDidChange call inside of _ewk_view_smart_focus_out() function.
Product: WebKit Reporter: Piotr Roguski <p.roguski>
Component: WebKit EFLAssignee: Piotr Roguski <p.roguski>
Severity: Normal CC: eric, g.czajkowski, gyuyoung.kim, kenneth, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Description Flags
Patch adding missing flag to viewStateDidChange call none

Description Piotr Roguski 2012-06-25 07:13:58 PDT
WebPageProxy::ViewIsFocused flag needs to be added to WebPageProxy::ViewFocusStateChange() call inside of _ewk_view_smart_focus_out(). Omitting this flag will prevent ViewFocusStateChange() from sending Messages::WebPage::SetFocused(bool):

void WebPageProxy::viewStateDidChange(ViewStateFlags flags)
    if (!isValid())

    if (flags & ViewIsFocused)
        process()->send(Messages::WebPage::SetFocused(m_pageClient->isViewFocused()), m_pageID);
/* ... */
Comment 1 Piotr Roguski 2012-06-27 06:37:14 PDT
Created attachment 149739 [details]
Patch adding missing flag to viewStateDidChange call
Comment 2 Grzegorz Czajkowski 2012-07-02 07:30:04 PDT
We need to send a message to WebProcess - SetFocused(false) on focus out. We are doing the same in WK1 directly on FocusController object:
Comment 3 WebKit Review Bot 2012-07-03 08:40:17 PDT
Comment on attachment 149739 [details]
Patch adding missing flag to viewStateDidChange call

Clearing flags on attachment: 149739

Committed r121770: <http://trac.webkit.org/changeset/121770>
Comment 4 WebKit Review Bot 2012-07-03 08:40:22 PDT
All reviewed patches have been landed.  Closing bug.