| Summary: | [EFL][WK2] Missing ViewIsFocused flag in viewStateDidChange call inside of _ewk_view_smart_focus_out() function. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Piotr Roguski <p.roguski> | ||||
| Component: | WebKit EFL | Assignee: | Piotr Roguski <p.roguski> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, g.czajkowski, gyuyoung.kim, kenneth, lucas.de.marchi, tonikitoo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
Created attachment 149739 [details]
Patch adding missing flag to viewStateDidChange call
LGTM. We need to send a message to WebProcess - SetFocused(false) on focus out. We are doing the same in WK1 directly on FocusController object: http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_view.cpp#L560 Comment on attachment 149739 [details] Patch adding missing flag to viewStateDidChange call Clearing flags on attachment: 149739 Committed r121770: <http://trac.webkit.org/changeset/121770> All reviewed patches have been landed. Closing bug. |
WebPageProxy::ViewIsFocused flag needs to be added to WebPageProxy::ViewFocusStateChange() call inside of _ewk_view_smart_focus_out(). Omitting this flag will prevent ViewFocusStateChange() from sending Messages::WebPage::SetFocused(bool): void WebPageProxy::viewStateDidChange(ViewStateFlags flags) { if (!isValid()) return; if (flags & ViewIsFocused) process()->send(Messages::WebPage::SetFocused(m_pageClient->isViewFocused()), m_pageID); /* ... */ }