Bug 89858

Summary: [GTK] Test /webkit2/WebKitWebView/permission-requests fails due to a runtime warning
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch xan.lopez: review+

Description Carlos Garcia Campos 2012-06-25 00:37:19 PDT 
It doesn't happen in the bots, though, so I guess it's a bug in some versions of geoclue.

/webkit2/WebKitWebView/permission-requests: 
** (Programs/WebKit2APITests/TestWebKitWebView:26401): WARNING **: Metadata for error domain "geoclue-error-quark" already registered

We don't register any error quark for geolocation errors, so this is a geoclue issue. Warnings are critical by default when running unit tests, so we need make them not critical for this particular test case to make it pass.
Comment 1 Carlos Garcia Campos 2012-06-25 00:42:45 PDT 
Created attachment 149260 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-25 00:47:03 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Xan Lopez 2012-06-25 00:53:13 PDT 
Comment on attachment 149260 [details]
Patch

r=me
Comment 4 Carlos Garcia Campos 2012-06-25 01:42:58 PDT 
Committed r121143: <http://trac.webkit.org/changeset/121143>