Bug 89857

Summary: [BlackBerry] Fill more data in device motion event
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit BlackBerryAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v3
tonikitoo: review+, tonikitoo: commit-queue-
Patch for landing none

Leo Yang
Reported 2012-06-25 00:11:55 PDT
We need to fill acceleration and rotation rate in device motion event for the blackberry porting.
Attachments
Patch (3.03 KB, patch)
2012-06-25 00:20 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Patch v2 (3.06 KB, patch)
2012-06-25 00:23 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Patch v3 (3.11 KB, patch)
2012-06-25 00:25 PDT, Leo Yang 		tonikitoo: review+
tonikitoo: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (3.23 KB, patch)
2012-06-25 19:23 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-06-25 00:20:39 PDT
Created attachment 149254 [details] Patch
Leo Yang
Comment 2 2012-06-25 00:23:18 PDT
Created attachment 149256 [details] Patch v2
Leo Yang
Comment 3 2012-06-25 00:25:46 PDT
Created attachment 149257 [details] Patch v3
Antonio Gomes
Comment 4 2012-06-25 09:56:38 PDT
Comment on attachment 149257 [details] Patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=149257&action=review > Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp:81 > + RefPtr<DeviceMotionData::Acceleration> acceleration = DeviceMotionData::Acceleration::create( > + true, event->acceleration.x, true, event->acceleration.y, true, event->acceleration.z); > + > + RefPtr<DeviceMotionData::Acceleration> accelerationIncludingGravity = DeviceMotionData::Acceleration::create( > + true, event->accelerationIncludingGravity.x, true, event->accelerationIncludingGravity.y, true, event->accelerationIncludingGravity.z); > + > + RefPtr<DeviceMotionData::RotationRate> rotationRate = DeviceMotionData::RotationRate::create( > + true, event->rotationRate.alpha, true, event->rotationRate.beta, true, event->rotationRate.gamma); please add comments to clarify what the boolean parameters are.
Leo Yang
Comment 5 2012-06-25 19:23:22 PDT
Created attachment 149431 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-06-25 21:32:06 PDT
Comment on attachment 149431 [details] Patch for landing Clearing flags on attachment: 149431 Committed r121225: <http://trac.webkit.org/changeset/121225>
Rob Buis
Comment 7 2013-01-04 09:45:06 PST
This was landed in r121225, closing.
Note You need to log in before you can comment on or make changes to this bug.