Bug 89836

Summary: Rename isPositioned to isOutOfFlowPositioned for clarity
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric, koivisto, macpherson, menard, mitz, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Simon Fraser (smfr)
Reported 2012-06-24 16:57:50 PDT
Rename isPositioned to isOutOfFlowPositioned for clarity
Attachments
Patch (107.13 KB, patch)
2012-06-24 16:59 PDT, Simon Fraser (smfr) 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-06-24 16:59:31 PDT
Created attachment 149207 [details] Patch
Antti Koivisto
Comment 2 2012-06-24 17:04:03 PDT
Comment on attachment 149207 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-06-24 17:05:57 PDT
Attachment 149207 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:288: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 4 2012-06-24 17:12:10 PDT
http://trac.webkit.org/changeset/121123
Note You need to log in before you can comment on or make changes to this bug.