Bug 89799

Summary: Web Inspector: fix timeline window auto-sizing logic
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED INVALID    
Severity: Normal CC: apavlov, bweinstein, keishi, loislo, pfeldman, pmuellr, rik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 116924    
Attachments:
Description Flags
Patch pfeldman: review+

Andrey Kosyakov
Reported 2012-06-22 17:58:49 PDT
r120891 introduced logic for automatically sizing of Timeline overview window as a matter of reducing the number of window refreshes while recording a new timeline. This doesn't work when there's a non-default window selected. 0. Open inspector, switch to Timeline panel. 1. Press record, record some events, press stop. 2. Select a window in the middle of overview. 3. Toggle "glue records" button back and forth. 4. Resize window to force a refresh EXPECTED: Window content does not change ACTUAL: Window content changes upon refresh
Attachments
Patch (3.40 KB, patch)
2012-06-22 18:06 PDT, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-06-22 18:06:11 PDT
Created attachment 149148 [details] Patch
Pavel Feldman
Comment 2 2012-06-22 18:13:05 PDT
Comment on attachment 149148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149148&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:674 > + recordsInWindow.length > lastVisibleLine) { poor indent.
Brian Burg
Comment 3 2014-12-12 14:36:37 PST
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.
Note You need to log in before you can comment on or make changes to this bug.