Bug 89779

Summary:

[BlackBerry] Add JSC statistics into about:memory

Product:

WebKit

Reporter:

Yong Li <yong.li.webkit>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch	rwlbuis: review-
try again	none
Try again	rwlbuis: review-
got rid of typos	none
the patch	rwlbuis: review-
to commit	none

Yong Li

Reported 2012-06-22 12:58:27 PDT

Add JSC statistics into about:memory page.

Attachments
the patch (8.04 KB, patch) 2012-06-25 11:17 PDT, Yong Li	rwlbuis: review-	Details Formatted Diff Diff
try again (7.97 KB, patch) 2012-06-25 11:26 PDT, Yong Li	no flags	Details Formatted Diff Diff
Try again (7.96 KB, patch) 2012-06-25 11:27 PDT, Yong Li	rwlbuis: review-	Details Formatted Diff Diff
got rid of typos (8.00 KB, patch) 2012-06-25 11:40 PDT, Yong Li	no flags	Details Formatted Diff Diff
the patch (666 bytes, patch) 2012-06-26 11:46 PDT, Yong Li	rwlbuis: review-	Details Formatted Diff Diff
to commit (1.27 KB, patch) 2012-06-26 11:52 PDT, Yong Li	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Yong Li

Comment 1 2012-06-25 11:17:16 PDT

Created attachment 149328 [details] the patch

Rob Buis

Comment 2 2012-06-25 11:20:36 PDT

Comment on attachment 149328 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=149328&action=review Some typos still. > Source/JavaScriptCore/PlatformBlackBerry.cmake:13 > +IF (NOT DEFINED PUBLIC_BIULD OR NOT PUBLIC_BIULD) Tyop? > Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:247 > + page += "<h2>JS engnine memory usage</h2><table align=\"center\" rules=\"all\">"; engine > Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:256 > + page += numberToHTMLTr("Protected gloal object count", mainHeap.protectedGlobalObjectCount()); global

Yong Li

Comment 3 2012-06-25 11:26:37 PDT

Created attachment 149332 [details] try again

Yong Li

Comment 4 2012-06-25 11:27:46 PDT

Created attachment 149334 [details] Try again

Rob Buis

Comment 5 2012-06-25 11:34:42 PDT

Comment on attachment 149334 [details] Try again View in context: https://bugs.webkit.org/attachment.cgi?id=149334&action=review Looks good, some typo fixes still + ChangeLog update. > Source/JavaScriptCore/ChangeLog:8 > + Set JITBytes for BlackBerry port. Please add that we use MemoryStatistics.cpp now and maybe why.

Yong Li

Comment 6 2012-06-25 11:40:57 PDT

Created attachment 149335 [details] got rid of typos

Rob Buis

Comment 7 2012-06-25 11:46:21 PDT

Comment on attachment 149335 [details] got rid of typos LGTM.

WebKit Review Bot

Comment 8 2012-06-25 17:08:39 PDT

Comment on attachment 149335 [details] got rid of typos Clearing flags on attachment: 149335 Committed r121196: <http://trac.webkit.org/changeset/121196>

WebKit Review Bot

Comment 9 2012-06-25 17:08:51 PDT

All reviewed patches have been landed. Closing bug.

Yong Li

Comment 10 2012-06-26 11:13:43 PDT

reopening to fix non-JIT build

Yong Li

Comment 11 2012-06-26 11:46:54 PDT

Created attachment 149577 [details] the patch

Rob Buis

Comment 12 2012-06-26 11:50:22 PDT

Comment on attachment 149577 [details] the patch LGTM.

Yong Li

Comment 13 2012-06-26 11:52:41 PDT

Created attachment 149578 [details] to commit

Rob Buis

Comment 14 2012-06-26 11:52:43 PDT

Comment on attachment 149577 [details] the patch Oops, misses ChangeLog.

WebKit Review Bot

Comment 15 2012-06-26 12:55:49 PDT

Comment on attachment 149578 [details] to commit Clearing flags on attachment: 149578 Committed r121282: <http://trac.webkit.org/changeset/121282>

WebKit Review Bot

Comment 16 2012-06-26 12:56:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.