Bug 89772

Summary: [BlackBerry] Tap highlight fade animations are added to overlay continuously during pinch zoom.
Product: WebKit Reporter: Andrew Lo <anlo>
Component: WebKit BlackBerryAssignee: Andrew Lo <anlo>
Status: RESOLVED FIXED    
Severity: Normal CC: levin+threading, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andrew Lo
Reported 2012-06-22 11:21:54 PDT
When pinch zooming & setting scroll position, the UI thread calls DefaultTapHighlight::hide continuously to make sure it isn't visible. Calling hide when it is already hidden should do nothing. However calling it from the UI thread now keeps creating & adding fade animations, since the visible flag check is in the webkit thread branch only. This results in the tap highlight being visible during zoom after the first fade out.
Attachments
Patch (3.80 KB, patch)
2012-06-22 11:27 PDT, Andrew Lo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Lo
Comment 1 2012-06-22 11:27:53 PDT
Created attachment 149072 [details] Patch
WebKit Review Bot
Comment 2 2012-06-22 12:16:48 PDT
Comment on attachment 149072 [details] Patch Clearing flags on attachment: 149072 Committed r121049: <http://trac.webkit.org/changeset/121049>
WebKit Review Bot
Comment 3 2012-06-22 12:17:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.