Bug 89771

Summary: Web Inspector: speed up Timeline and Elements panel rendering
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cr-linux-01
none
Patch none

Pavel Feldman
Reported 2012-06-22 11:10:27 PDT
Few findings using the new timeline are fixed
Attachments
Patch (7.89 KB, patch)
2012-06-22 11:15 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (681.41 KB, application/zip)
2012-06-22 13:06 PDT, WebKit Review Bot 		no flags
Details
Patch (9.67 KB, patch)
2012-06-22 15:03 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-06-22 11:15:03 PDT
Created attachment 149066 [details] Patch
Andrey Adaikin
Comment 2 2012-06-22 11:21:54 PDT
Comment on attachment 149066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149066&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:750 > this._containerElement.scrollTop = (totalHeight - this._containerElement.offsetHeight); also update this._scrollTop here?
Andrey Kosyakov
Comment 3 2012-06-22 11:55:11 PDT
Comment on attachment 149066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149066&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1848 > + originalScrollTop = treeOutlineContainerElement.scrollTop; var? > Source/WebCore/inspector/front-end/TimelinePanel.js:-529 > - this._closeRecordDetails(); > - this._scheduleRefresh(false); Why did this go?
WebKit Review Bot
Comment 4 2012-06-22 13:06:05 PDT
Comment on attachment 149066 [details] Patch Attachment 149066 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13084081 New failing tests: inspector/debugger/dom-breakpoints.html
WebKit Review Bot
Comment 5 2012-06-22 13:06:15 PDT
Created attachment 149090 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Pavel Feldman
Comment 6 2012-06-22 15:03:20 PDT
Created attachment 149112 [details] Patch
Andrey Kosyakov
Comment 7 2012-06-22 18:14:41 PDT
Comment on attachment 149112 [details] Patch LGTM
WebKit Review Bot
Comment 8 2012-06-24 00:27:21 PDT
Comment on attachment 149112 [details] Patch Clearing flags on attachment: 149112 Committed r121112: <http://trac.webkit.org/changeset/121112>
WebKit Review Bot
Comment 9 2012-06-24 00:27:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.