Bug 89761

Summary: [Chromium/Skia] Increase the GrContext texture cache count cap to 2K
Product: WebKit Reporter: Brian Salomon <bsalomon>
Component: CanvasAssignee: Brian Salomon <bsalomon>
Status: RESOLVED FIXED    
Severity: Normal CC: bsalomon, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Brian Salomon
Reported 2012-06-22 08:48:27 PDT
Increase the GrContext texture cache count cap to 2K
Attachments
Patch (1.39 KB, patch)
2012-06-22 08:52 PDT, Brian Salomon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Salomon
Comment 1 2012-06-22 08:52:12 PDT
Created attachment 149035 [details] Patch
Brian Salomon
Comment 2 2012-06-22 08:56:07 PDT
I had removed the count cap from Skia but it proved to be problematic. Randomly changing gradients produce many tiny textures. Managing lots of textures causes perf problems on some drivers. We have plans to change how gradient color tables work (http://code.google.com/p/skia/issues/detail?id=670) but if tons of small textures is a problem then it probably makes sense to keep the cap anyway.
Stephen White
Comment 3 2012-06-22 10:25:25 PDT
Comment on attachment 149035 [details] Patch OK. r=me
Brian Salomon
Comment 4 2012-06-22 10:50:49 PDT
Oops.. I forgot to set c? after uploading.
WebKit Review Bot
Comment 5 2012-06-22 11:32:22 PDT
Comment on attachment 149035 [details] Patch Clearing flags on attachment: 149035 Committed r121044: <http://trac.webkit.org/changeset/121044>
WebKit Review Bot
Comment 6 2012-06-22 11:32:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.