Bug 89755

Summary: [Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: WebKit QtAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, dglazkov, hausmann, vestbo, webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-05 none

Alexis Menard (darktears)
Reported 2012-06-22 05:52:12 PDT
[Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
Attachments
Patch (1.61 KB, patch)
2012-06-22 05:53 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (3.61 KB, patch)
2012-07-02 05:46 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-05 (339.47 KB, application/zip)
2012-07-02 07:17 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2012-06-22 05:53:55 PDT
Created attachment 149006 [details] Patch
Simon Hausmann
Comment 2 2012-06-26 09:15:45 PDT
Comment on attachment 149006 [details] Patch Can you make a unit test for this behaviour?
Alexis Menard (darktears)
Comment 3 2012-07-02 05:46:39 PDT
Created attachment 150404 [details] Patch
WebKit Review Bot
Comment 4 2012-07-02 07:17:37 PDT
Comment on attachment 150404 [details] Patch Attachment 150404 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13135074 New failing tests: plugins/iframe-shims.html
WebKit Review Bot
Comment 5 2012-07-02 07:17:41 PDT
Created attachment 150417 [details] Archive of layout-test-results from gce-cr-linux-05 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Alexis Menard (darktears)
Comment 6 2012-07-02 07:50:08 PDT
(In reply to comment #5) > Created an attachment (id=150417) [details] > Archive of layout-test-results from gce-cr-linux-05 > > The attached test failures were seen while running run-webkit-tests on the chromium-ews. > Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid False positive obviously as I fix Qt and Qt only :)
Adam Barth
Comment 7 2012-07-02 09:13:50 PDT
> False positive obviously as I fix Qt and Qt only :) Yes, sorry. This was caused by the migration. I'm investigating and will fix.
Alexis Menard (darktears)
Comment 8 2012-07-02 09:16:46 PDT
(In reply to comment #7) > > False positive obviously as I fix Qt and Qt only :) > > Yes, sorry. This was caused by the migration. I'm investigating and will fix. Don't worry it's no big deal.
WebKit Review Bot
Comment 9 2012-07-03 06:32:47 PDT
Comment on attachment 150404 [details] Patch Clearing flags on attachment: 150404 Committed r121761: <http://trac.webkit.org/changeset/121761>
WebKit Review Bot
Comment 10 2012-07-03 06:32:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.