Summary: | [Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject(). | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexis Menard (darktears) <menard> | ||||||||
Component: | WebKit Qt | Assignee: | Alexis Menard (darktears) <menard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, cmarcelo, dglazkov, hausmann, vestbo, webkit.review.bot, zoltan | ||||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alexis Menard (darktears)
2012-06-22 05:52:12 PDT
Created attachment 149006 [details]
Patch
Comment on attachment 149006 [details]
Patch
Can you make a unit test for this behaviour?
Created attachment 150404 [details]
Patch
Comment on attachment 150404 [details] Patch Attachment 150404 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13135074 New failing tests: plugins/iframe-shims.html Created attachment 150417 [details]
Archive of layout-test-results from gce-cr-linux-05
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
(In reply to comment #5) > Created an attachment (id=150417) [details] > Archive of layout-test-results from gce-cr-linux-05 > > The attached test failures were seen while running run-webkit-tests on the chromium-ews. > Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid False positive obviously as I fix Qt and Qt only :) > False positive obviously as I fix Qt and Qt only :)
Yes, sorry. This was caused by the migration. I'm investigating and will fix.
(In reply to comment #7) > > False positive obviously as I fix Qt and Qt only :) > > Yes, sorry. This was caused by the migration. I'm investigating and will fix. Don't worry it's no big deal. Comment on attachment 150404 [details] Patch Clearing flags on attachment: 150404 Committed r121761: <http://trac.webkit.org/changeset/121761> All reviewed patches have been landed. Closing bug. |