Bug 89739

Summary: Web Inspector: Add frontend-side Entry object to FileSystemModel
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: Web Inspector (Deprecated)Assignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 68203, 73301, 87856    
Attachments:
Description Flags
Patch
none
Patch none

Description Taiju Tsuiki 2012-06-21 23:00:35 PDT 
I'd like to add Entry, Directory and File object under FileSystemModel that represent browser side entries.
It will provide handy way to manipulate entries.

This is split out bug/patch from http://webkit.org/b/73301 (Web Inspector: Add FileSystemView).
Comment 1 Taiju Tsuiki 2012-06-21 23:13:53 PDT 
Created attachment 148965 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-06-22 03:08:22 PDT 
Comment on attachment 148965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148965&action=review

> Source/WebCore/inspector/front-end/FileSystemModel.js:287
> +    get fileSystemModel() { return this._fileSystemModel; },

Here and below:

get fileSystemModel()
{
    return this._fileSystemModel;
},

Also could you please add compiler annotations to getters (where possible).
Comment 3 Taiju Tsuiki 2012-06-22 03:17:42 PDT 
Created attachment 148989 [details]
Patch
Comment 4 Taiju Tsuiki 2012-06-22 03:19:02 PDT 
Comment on attachment 148965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148965&action=review

>> Source/WebCore/inspector/front-end/FileSystemModel.js:287
>> +    get fileSystemModel() { return this._fileSystemModel; },
> 
> Here and below:
> 
> get fileSystemModel()
> {
>     return this._fileSystemModel;
> },
> 
> Also could you please add compiler annotations to getters (where possible).

Done.
Comment 5 WebKit Review Bot 2012-06-22 05:36:12 PDT 
Comment on attachment 148989 [details]
Patch

Clearing flags on attachment: 148989

Committed r121017: <http://trac.webkit.org/changeset/121017>
Comment 6 WebKit Review Bot 2012-06-22 05:36:16 PDT 
All reviewed patches have been landed.  Closing bug.