Bug 89739

Summary:

Web Inspector: Add frontend-side Entry object to FileSystemModel

Product:

WebKit

Reporter:

Taiju Tsuiki <tzik>

Component:

Web Inspector (Deprecated)

Assignee:

Taiju Tsuiki <tzik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

68203, 73301, 87856

Attachments:

Description	Flags
Patch	none
Patch	none

Taiju Tsuiki

Reported 2012-06-21 23:00:35 PDT

I'd like to add Entry, Directory and File object under FileSystemModel that represent browser side entries. It will provide handy way to manipulate entries. This is split out bug/patch from http://webkit.org/b/73301 (Web Inspector: Add FileSystemView).

Attachments
Patch (6.31 KB, patch) 2012-06-21 23:13 PDT, Taiju Tsuiki	no flags	Details Formatted Diff Diff
Patch (6.93 KB, patch) 2012-06-22 03:17 PDT, Taiju Tsuiki	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Taiju Tsuiki

Comment 1 2012-06-21 23:13:53 PDT

Created attachment 148965 [details] Patch

Vsevolod Vlasov

Comment 2 2012-06-22 03:08:22 PDT

Comment on attachment 148965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148965&action=review > Source/WebCore/inspector/front-end/FileSystemModel.js:287 > + get fileSystemModel() { return this._fileSystemModel; }, Here and below: get fileSystemModel() { return this._fileSystemModel; }, Also could you please add compiler annotations to getters (where possible).

Taiju Tsuiki

Comment 3 2012-06-22 03:17:42 PDT

Created attachment 148989 [details] Patch

Taiju Tsuiki

Comment 4 2012-06-22 03:19:02 PDT

Comment on attachment 148965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148965&action=review >> Source/WebCore/inspector/front-end/FileSystemModel.js:287 >> + get fileSystemModel() { return this._fileSystemModel; }, > > Here and below: > > get fileSystemModel() > { > return this._fileSystemModel; > }, > > Also could you please add compiler annotations to getters (where possible). Done.

WebKit Review Bot

Comment 5 2012-06-22 05:36:12 PDT

Comment on attachment 148989 [details] Patch Clearing flags on attachment: 148989 Committed r121017: <http://trac.webkit.org/changeset/121017>

WebKit Review Bot

Comment 6 2012-06-22 05:36:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.