Bug 89738

Summary: CSS3 calc: transitions starting and ending with a calc expression move to end state
Product: WebKit Reporter: Mike Lawther <mikelawther>
Component: New BugsAssignee: Mike Lawther <mikelawther>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, simon.fraser, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Mike Lawther
Reported 2012-06-21 22:58:51 PDT
CSS3 calc: transitions starting and ending with a calc expression move to end state
Attachments
Patch (4.35 KB, patch)
2012-06-21 23:03 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch (4.41 KB, patch)
2012-06-22 08:00 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.80 KB, patch)
2012-06-24 17:34 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mike Lawther
Comment 1 2012-06-21 23:03:40 PDT
Created attachment 148963 [details] Patch
Mike Lawther
Comment 2 2012-06-22 08:00:15 PDT
Created attachment 149028 [details] Patch
Tony Chang
Comment 3 2012-06-22 11:17:17 PDT
Comment on attachment 149028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149028&action=review This > LayoutTests/css3/calc/transition-start-end-with-calc.html:7 > + -webkit-transition: all 0.01s; > + -moz-transition: all 0.01s; Should we use LayoutTests/transitions/resources/transition-test-helpers.js instead of a fast transition?
Mike Lawther
Comment 4 2012-06-24 17:34:46 PDT
Created attachment 149214 [details] Patch for landing
Mike Lawther
Comment 5 2012-06-24 17:51:05 PDT
> Should we use LayoutTests/transitions/resources/transition-test-helpers.js instead of a fast transition? Thanks for the review Tony! I was originally going to use the helper, but since I only wanted start and end I figured I could get away without it :) Anyway, I updated to use the helper. This is part of me getting transitions working for calc so I'm going to have to use the helper sooner or later :)
WebKit Review Bot
Comment 6 2012-06-24 20:16:25 PDT
Comment on attachment 149214 [details] Patch for landing Clearing flags on attachment: 149214 Committed r121132: <http://trac.webkit.org/changeset/121132>
WebKit Review Bot
Comment 7 2012-06-24 20:16:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.