Bug 89728

Summary: BitmapImage duplicates code to calculate size
Product: WebKit Reporter: Dean Jackson <dino>
Component: ImagesAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Dean Jackson
Reported 2012-06-21 18:31:47 PDT
BitmapImage has some code duplication to ask the source for the size.
Attachments
Patch (2.78 KB, patch)
2012-06-21 18:42 PDT, Dean Jackson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-06-21 18:32:24 PDT
<rdar://problem/11724321>
Dean Jackson
Comment 2 2012-06-21 18:42:39 PDT
Created attachment 148938 [details] Patch
Darin Adler
Comment 3 2012-06-21 19:10:55 PDT
Comment on attachment 148938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148938&action=review > Source/WebCore/ChangeLog:21 > + * platform/graphics/BitmapImage.cpp: > + (WebCore::BitmapImage::updateSize): > + (WebCore): > + (WebCore::BitmapImage::size): > + (WebCore::BitmapImage::sizeRespectingOrientation): > + * platform/graphics/BitmapImage.h: > + (BitmapImage): I really like per-function comments, and here they would be so easy to write! > Source/WebCore/platform/graphics/BitmapImage.cpp:183 > if (m_sizeAvailable && !m_haveSize) { Might be nice to use early return since this function now is only about updating. > Source/WebCore/platform/graphics/BitmapImage.h:267 > + void updateSize() const; This could be private rather than protected.
Dean Jackson
Comment 4 2012-06-22 12:14:34 PDT
Committed r121048: <http://trac.webkit.org/changeset/121048>
Note You need to log in before you can comment on or make changes to this bug.