Bug 89726

Summary:

op_resolve_global should not prevent DFG inlining

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	barraclough: review+

Description Filip Pizlo 2012-06-21 18:19:58 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2012-06-21 18:22:15 PDT

Created attachment 148935 [details]
the patch

Comment 2 WebKit Review Bot 2012-06-21 18:27:30 PDT

Attachment 148935 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.h:68:  DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Filip Pizlo 2012-06-21 18:33:49 PDT

Landed in http://trac.webkit.org/changeset/120989