Bug 89716

Summary: Web Inspector: exception in TimelinePresentationModel when recording timeline
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+, pfeldman: commit-queue+

Description Andrey Kosyakov 2012-06-21 17:21:43 PDT
0. Open WebInspector
1. Switch to Timeline panel
2. Press record
3. Reload
4. Observe JS exception in TimelinePresentationModel.filterRecords

This is a regression introduced by r120891
Comment 1 Andrey Kosyakov 2012-06-21 17:23:11 PDT
Created attachment 148918 [details]
Patch
Comment 2 Pavel Feldman 2012-06-21 17:50:05 PDT
Comment on attachment 148918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148918&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:499
> +        var haveVisibleRecords = false;

hasVisibleRecords
Comment 3 Andrey Kosyakov 2012-06-21 18:30:37 PDT
Committed r120988: <http://trac.webkit.org/changeset/120988>