Bug 89685

Summary: [Qt] Allow DumpRenderTree to dump about:blank
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Description Zoltan Horvath 2012-06-21 12:35:46 PDT
We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports, additionaly this behavior is required for running WTR performance tests.
Comment 1 Zoltan Horvath 2012-06-21 12:37:00 PDT
Created attachment 148864 [details]
proposed patch
Comment 2 Ryosuke Niwa 2012-06-21 14:41:25 PDT
Comment on attachment 148864 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148864&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:704
> +            || line == QLatin1String("about:blank")) {

Should we allow all "about:"?
Comment 3 Zoltan Horvath 2012-06-22 00:13:59 PDT
(In reply to comment #2)
> (From update of attachment 148864 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148864&action=review
> 
> > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:704
> > +            || line == QLatin1String("about:blank")) {
> 
> Should we allow all "about:"?

Thanks for the review. 

I don't see any other usecase for loading about:* in DRT, so I'm going to check this version in. We can modify later if we need.
Comment 4 Zoltan Horvath 2012-06-22 00:17:02 PDT
Comment on attachment 148864 [details]
proposed patch

Clearing flags on attachment: 148864

Committed r121009: <http://trac.webkit.org/changeset/121009>
Comment 5 Zoltan Horvath 2012-06-22 00:17:08 PDT
All reviewed patches have been landed.  Closing bug.