Bug 89685 - [Qt] Allow DumpRenderTree to dump about:blank
Summary: [Qt] Allow DumpRenderTree to dump about:blank
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 12:35 PDT by Zoltan Horvath
Modified: 2012-06-22 00:17 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (1.39 KB, patch)
2012-06-21 12:37 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2012-06-21 12:35:46 PDT 
We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports, additionaly this behavior is required for running WTR performance tests.
Comment 1 Zoltan Horvath 2012-06-21 12:37:00 PDT 
Created attachment 148864 [details]
proposed patch
Comment 2 Ryosuke Niwa 2012-06-21 14:41:25 PDT 
Comment on attachment 148864 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148864&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:704
> +            || line == QLatin1String("about:blank")) {

Should we allow all "about:"?
Comment 3 Zoltan Horvath 2012-06-22 00:13:59 PDT 
(In reply to comment #2)
> (From update of attachment 148864 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148864&action=review
> 
> > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:704
> > +            || line == QLatin1String("about:blank")) {
> 
> Should we allow all "about:"?

Thanks for the review. 

I don't see any other usecase for loading about:* in DRT, so I'm going to check this version in. We can modify later if we need.
Comment 4 Zoltan Horvath 2012-06-22 00:17:02 PDT 
Comment on attachment 148864 [details]
proposed patch

Clearing flags on attachment: 148864

Committed r121009: <http://trac.webkit.org/changeset/121009>
Comment 5 Zoltan Horvath 2012-06-22 00:17:08 PDT 
All reviewed patches have been landed.  Closing bug.