Bug 89685 – [Qt] Allow DumpRenderTree to dump about:blank

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Zoltan Horvath]

We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports, additionaly this behavior is required for running WTR performance tests.

[Zoltan Horvath]

Created attachment 148864 [details]
proposed patch

[Ryosuke Niwa]

Comment on attachment 148864 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148864&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:704
> +            || line == QLatin1String("about:blank")) {

Should we allow all "about:"?

[Zoltan Horvath]

(In reply to comment #2)
> (From update of attachment 148864 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148864&action=review
> 
> > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:704
> > +            || line == QLatin1String("about:blank")) {
> 
> Should we allow all "about:"?

Thanks for the review. 

I don't see any other usecase for loading about:* in DRT, so I'm going to check this version in. We can modify later if we need.

[Zoltan Horvath]

Comment on attachment 148864 [details]
proposed patch

Clearing flags on attachment: 148864

Committed r121009: <http://trac.webkit.org/changeset/121009>

[Zoltan Horvath]

All reviewed patches have been landed.  Closing bug.