Bug 89684

Summary:

[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons

Product:

WebKit

Reporter:

Parth Patel <parpatel>

Component:

WebKit BlackBerry

Assignee:

Parth Patel <parpatel>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mifenton, tonikitoo, webkit.review.bot, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Update setting instance access to use instance() instead of get().	mifenton: review-
Update setting instance access to use instance() instead of get().	none
Build Fix-Typo Update setting instance access to use instance() instead of get().	yong.li.webkit: review-
Build Fix-Typo Update setting instance access to use instance() instead of get().	none

Parth Patel

Reported 2012-06-21 12:08:39 PDT

[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons

Attachments
Update setting instance access to use instance() instead of get(). (15.11 KB, patch) 2012-06-21 13:22 PDT, Parth Patel	mifenton: review-	Details Formatted Diff Diff
Update setting instance access to use instance() instead of get(). (13.28 KB, patch) 2012-06-21 13:34 PDT, Parth Patel	no flags	Details Formatted Diff Diff
Build Fix-Typo Update setting instance access to use instance() instead of get(). (1.31 KB, patch) 2012-06-22 07:27 PDT, Parth Patel	yong.li.webkit: review-	Details Formatted Diff Diff
Build Fix-Typo Update setting instance access to use instance() instead of get(). (2.29 KB, patch) 2012-06-22 07:34 PDT, Parth Patel	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Parth Patel

Comment 1 2012-06-21 13:22:49 PDT

Created attachment 148869 [details] Update setting instance access to use instance() instead of get(). [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons

Mike Fenton

Comment 2 2012-06-21 13:25:26 PDT

Comment on attachment 148869 [details] Update setting instance access to use instance() instead of get(). Includes undesired change in WebCore

Parth Patel

Comment 3 2012-06-21 13:34:33 PDT

Created attachment 148875 [details] Update setting instance access to use instance() instead of get(). [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons

WebKit Review Bot

Comment 4 2012-06-21 18:20:08 PDT

Comment on attachment 148875 [details] Update setting instance access to use instance() instead of get(). Clearing flags on attachment: 148875 Committed r120987: <http://trac.webkit.org/changeset/120987>

WebKit Review Bot

Comment 5 2012-06-21 18:20:12 PDT

All reviewed patches have been landed. Closing bug.

Parth Patel

Comment 6 2012-06-22 07:27:10 PDT

Created attachment 149022 [details] Build Fix-Typo Update setting instance access to use instance() instead of get(). Typo error

Yong Li

Comment 7 2012-06-22 07:28:31 PDT

Comment on attachment 149022 [details] Build Fix-Typo Update setting instance access to use instance() instead of get(). Changelog missed?

Mike Fenton

Comment 8 2012-06-22 07:29:01 PDT

Build Fix required.

Parth Patel

Comment 9 2012-06-22 07:34:06 PDT

Created attachment 149023 [details] Build Fix-Typo Update setting instance access to use instance() instead of get(). Build Fix Typo

WebKit Review Bot

Comment 10 2012-06-22 09:24:04 PDT

Comment on attachment 149023 [details] Build Fix-Typo Update setting instance access to use instance() instead of get(). Clearing flags on attachment: 149023 Committed r121029: <http://trac.webkit.org/changeset/121029>

WebKit Review Bot

Comment 11 2012-06-22 09:24:10 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.