Summary: | [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons | ||
---|---|---|---|
Product: | WebKit | Reporter: | Parth Patel <parpatel> |
Component: | WebKit BlackBerry | Assignee: | Parth Patel <parpatel> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | mifenton, tonikitoo, webkit.review.bot, yong.li.webkit |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
Parth Patel
2012-06-21 12:08:39 PDT
Created attachment 148869 [details]
Update setting instance access to use instance() instead of get().
[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Comment on attachment 148869 [details]
Update setting instance access to use instance() instead of get().
Includes undesired change in WebCore
Created attachment 148875 [details]
Update setting instance access to use instance() instead of get().
[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Comment on attachment 148875 [details] Update setting instance access to use instance() instead of get(). Clearing flags on attachment: 148875 Committed r120987: <http://trac.webkit.org/changeset/120987> All reviewed patches have been landed. Closing bug. Created attachment 149022 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().
Typo error
Comment on attachment 149022 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().
Changelog missed?
Build Fix required. Created attachment 149023 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().
Build Fix Typo
Comment on attachment 149023 [details] Build Fix-Typo Update setting instance access to use instance() instead of get(). Clearing flags on attachment: 149023 Committed r121029: <http://trac.webkit.org/changeset/121029> All reviewed patches have been landed. Closing bug. |