Bug 89684

Summary: [Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Product: WebKit Reporter: Parth Patel <parpatel>
Component: WebKit BlackBerryAssignee: Parth Patel <parpatel>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update setting instance access to use instance() instead of get().
mifenton: review-
Update setting instance access to use instance() instead of get().
none
Build Fix-Typo Update setting instance access to use instance() instead of get().
yong.li.webkit: review-
Build Fix-Typo Update setting instance access to use instance() instead of get(). none

Description Parth Patel 2012-06-21 12:08:39 PDT
[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Comment 1 Parth Patel 2012-06-21 13:22:49 PDT
Created attachment 148869 [details]
Update setting instance access to use instance() instead of get().

[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Comment 2 Mike Fenton 2012-06-21 13:25:26 PDT
Comment on attachment 148869 [details]
Update setting instance access to use instance() instead of get().

Includes undesired change in WebCore
Comment 3 Parth Patel 2012-06-21 13:34:33 PDT
Created attachment 148875 [details]
Update setting instance access to use instance() instead of get().

[Blackberry] BlackBerry::Platform::Settings::get() rename to BlackBerry::Platform::Settings::instance() to make it consistent with our other singletons
Comment 4 WebKit Review Bot 2012-06-21 18:20:08 PDT
Comment on attachment 148875 [details]
Update setting instance access to use instance() instead of get().

Clearing flags on attachment: 148875

Committed r120987: <http://trac.webkit.org/changeset/120987>
Comment 5 WebKit Review Bot 2012-06-21 18:20:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Parth Patel 2012-06-22 07:27:10 PDT
Created attachment 149022 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().

Typo error
Comment 7 Yong Li 2012-06-22 07:28:31 PDT
Comment on attachment 149022 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().

Changelog missed?
Comment 8 Mike Fenton 2012-06-22 07:29:01 PDT
Build Fix required.
Comment 9 Parth Patel 2012-06-22 07:34:06 PDT
Created attachment 149023 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().

Build Fix Typo
Comment 10 WebKit Review Bot 2012-06-22 09:24:04 PDT
Comment on attachment 149023 [details]
Build Fix-Typo Update setting instance access to use instance() instead of get().

Clearing flags on attachment: 149023

Committed r121029: <http://trac.webkit.org/changeset/121029>
Comment 11 WebKit Review Bot 2012-06-22 09:24:10 PDT
All reviewed patches have been landed.  Closing bug.