Summary: | Make FormControlState capable to store multiple values | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ddkilzer, jberlin, kinuko, marja, morrita, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 23346, 89623, 89847 | ||||||
Attachments: |
|
Description
Kent Tamura
2012-06-20 18:44:55 PDT
Created attachment 148719 [details]
Patch
Comment on attachment 148719 [details] Patch Clearing flags on attachment: 148719 Committed r121004: <http://trac.webkit.org/changeset/121004> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > (From update of attachment 148719 [details]) > Clearing flags on attachment: 148719 > > Committed r121004: <http://trac.webkit.org/changeset/121004> This broke the i386 build: Source/WebCore/html/FormController.cpp:62:36: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'size_t' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32] state.m_values.reserveCapacity(valueSize); ~~~~~ ^~~~~~~~~ (In reply to comment #2) > (From update of attachment 148719 [details]) > Clearing flags on attachment: 148719 > > Committed r121004: <http://trac.webkit.org/changeset/121004> This caused a build failure on 32-bit architectures. Follow-up build fix in r121032. <http://trac.webkit.org/changeset/121032> (In reply to comment #5) > > Committed r121004: <http://trac.webkit.org/changeset/121004> > > This caused a build failure on 32-bit architectures. Follow-up build fix in r121032. > > <http://trac.webkit.org/changeset/121032> Thank you for the fix! We should have a 32 bit EWS. |