Bug 89626

Summary: Non-fixed length margins don't work with align=center
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed fix 1. Use minimumValueForLength instead of Lengt::value. none

Julien Chaffraix
Reported 2012-06-20 18:26:15 PDT
Follow up of bug 89515, the attached bug nicely handled the fixed length case (100px) but it didn't handle non-fixed length (for example, calculated or percent) properly. It turns out calling Length::value() on an arbitrary Length is not a good idea. Patch forthcoming.
Attachments
Proposed fix 1. Use minimumValueForLength instead of Lengt::value. (7.79 KB, patch)
2012-06-20 19:25 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-06-20 19:25:26 PDT
Created attachment 148713 [details] Proposed fix 1. Use minimumValueForLength instead of Lengt::value.
Levi Weintraub
Comment 2 2012-06-21 10:06:38 PDT
Comment on attachment 148713 [details] Proposed fix 1. Use minimumValueForLength instead of Lengt::value. Good catch! That certainly will not do.
WebKit Review Bot
Comment 3 2012-06-21 10:15:34 PDT
Comment on attachment 148713 [details] Proposed fix 1. Use minimumValueForLength instead of Lengt::value. Clearing flags on attachment: 148713 Committed r120934: <http://trac.webkit.org/changeset/120934>
WebKit Review Bot
Comment 4 2012-06-21 10:15:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.