Bug 89623

Summary: Selected option is not restored correctly
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: e.ryabtsev, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89628    
Bug Blocks: 23346    
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch 3 morrita: review+

Kent Tamura
Reported 2012-06-20 17:49:21 PDT
http://code.google.com/p/chromium/issues/detail?id=125509 If the index of the selected option is changed after <select> parsing, the selection is not restored correctly because we save the selection index. We need to save the value string for <select>.
Attachments
Patch (10.93 KB, patch)
2012-06-22 00:15 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (11.16 KB, patch)
2012-06-24 18:29 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 3 (11.19 KB, patch)
2012-06-24 18:29 PDT, Kent Tamura 		morrita: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-06-22 00:15:22 PDT
Created attachment 148972 [details] Patch
Hajime Morrita
Comment 2 2012-06-24 17:55:21 PDT
Comment on attachment 148972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148972&action=review > Source/WebCore/ChangeLog:36 > + Test: fast/forms/select/select-state-restore.html I hope we have another test which covers option element removal. > LayoutTests/fast/forms/select/select-state-restore.html:8 > +<p>Test to NOT save state for non-edited controls</p> Is this message intended?
Kent Tamura
Comment 3 2012-06-24 17:59:35 PDT
Comment on attachment 148972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148972&action=review >> Source/WebCore/ChangeLog:36 >> + Test: fast/forms/select/select-state-restore.html > > I hope we have another test which covers option element removal. ok, I'll update the test so that it covers removal. >> LayoutTests/fast/forms/select/select-state-restore.html:8 >> +<p>Test to NOT save state for non-edited controls</p> > > Is this message intended? Oh, it's a copypasta. I'll update it.
Kent Tamura
Comment 4 2012-06-24 18:29:03 PDT
Created attachment 149218 [details] Patch 2
Kent Tamura
Comment 5 2012-06-24 18:29:55 PDT
Created attachment 149219 [details] Patch 3 Remove TABs
Kent Tamura
Comment 6 2012-06-24 18:47:51 PDT
Committed r121128: <http://trac.webkit.org/changeset/121128>
Kent Tamura
Comment 7 2012-08-18 17:41:03 PDT
*** Bug 86855 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.