Bug 89617

Summary: DFG should optimize ResolveGlobal
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
the patch oliver: review+, buildbot: commit-queue-

Filip Pizlo
Reported 2012-06-20 17:05:51 PDT
And it should even do specific function optimizations on common things, like the Array constructor.
Attachments
work in progress (24.86 KB, patch)
2012-06-20 17:13 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (28.56 KB, patch)
2012-06-20 17:20 PDT, Filip Pizlo 		oliver: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-06-20 17:13:28 PDT
Created attachment 148686 [details] work in progress
WebKit Review Bot
Comment 2 2012-06-20 17:17:00 PDT
Attachment 148686 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/JavaScriptCore.xcode..." exit_code: 1 Source/JavaScriptCore/runtime/JSObject.h:49: The parameter name "cell" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2012-06-20 17:20:31 PDT
Created attachment 148688 [details] the patch
Build Bot
Comment 4 2012-06-20 18:05:24 PDT
Comment on attachment 148688 [details] the patch Attachment 148688 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13023029
Filip Pizlo
Comment 5 2012-06-20 18:39:06 PDT
Landed in http://trac.webkit.org/changeset/120897
Note You need to log in before you can comment on or make changes to this bug.