Bug 89617 - DFG should optimize ResolveGlobal
Summary: DFG should optimize ResolveGlobal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 17:05 PDT by Filip Pizlo
Modified: 2012-06-20 18:39 PDT (History)
2 users (show)

See Also:

Attachments
work in progress (24.86 KB, patch)
2012-06-20 17:13 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (28.56 KB, patch)
2012-06-20 17:20 PDT, Filip Pizlo 		oliver: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-20 17:05:51 PDT 
And it should even do specific function optimizations on common things, like the Array constructor.
Comment 1 Filip Pizlo 2012-06-20 17:13:28 PDT 
Created attachment 148686 [details]
work in progress
Comment 2 WebKit Review Bot 2012-06-20 17:17:00 PDT 
Attachment 148686 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/JavaScriptCore.xcode..." exit_code: 1
Source/JavaScriptCore/runtime/JSObject.h:49:  The parameter name "cell" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2012-06-20 17:20:31 PDT 
Created attachment 148688 [details]
the patch
Comment 4 Build Bot 2012-06-20 18:05:24 PDT 
Comment on attachment 148688 [details]
the patch

Attachment 148688 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13023029
Comment 5 Filip Pizlo 2012-06-20 18:39:06 PDT 
Landed in http://trac.webkit.org/changeset/120897