Bug 89592

Summary: Web Inspector: [WebGL] Add injected WebGL module class
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 89530    
Bug Blocks: 88973    
Attachments:
Description Flags
Patch
none
Rebased patch to land
none
Patch to land none

Description Andrey Adaikin 2012-06-20 12:12:35 PDT
Adding a new InjectedScriptWebGLModule class and moving WebGL-related stuff out of InjectedScriptManager class.
Comment 1 Andrey Adaikin 2012-06-20 12:18:24 PDT
Created attachment 148624 [details]
Patch
Comment 2 Pavel Feldman 2012-06-20 19:24:17 PDT
Comment on attachment 148624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148624&action=review

> Source/WebCore/inspector/InjectedScriptWebGLModule.cpp:46
> +    : InjectedScriptModule("InjectedScriptWebGLModule")

"webgl"?
Comment 3 WebKit Review Bot 2012-06-20 19:28:05 PDT
Comment on attachment 148624 [details]
Patch

Rejecting attachment 148624 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
anager.h
patching file Source/WebCore/inspector/InjectedScriptModule.cpp
patching file Source/WebCore/inspector/InjectedScriptModule.h
patching file Source/WebCore/inspector/InjectedScriptWebGLModule.cpp
patching file Source/WebCore/inspector/InjectedScriptWebGLModule.h
patching file Source/WebCore/inspector/InspectorWebGLAgent.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13012097
Comment 4 Andrey Adaikin 2012-06-20 21:52:15 PDT
Created attachment 148727 [details]
Rebased patch to land
Comment 5 Andrey Adaikin 2012-06-20 21:55:49 PDT
Comment on attachment 148624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148624&action=review

>> Source/WebCore/inspector/InjectedScriptWebGLModule.cpp:46
>> +    : InjectedScriptModule("InjectedScriptWebGLModule")
> 
> "webgl"?

For InjectedScript it was "InjectedScript". This string will be also passed into the InspectorInstrumentation::willCallFunction() method.
Comment 6 Yury Semikhatsky 2012-06-21 01:22:31 PDT
Comment on attachment 148727 [details]
Rebased patch to land

View in context: https://bugs.webkit.org/attachment.cgi?id=148727&action=review

> Source/WebCore/inspector/InjectedScriptWebGLModule.h:49
> +    static InjectedScriptWebGLModule injectedModuleForState(InjectedScriptManager*, ScriptState*);

ensureModuleInjectedForState or simply moduleForState?

> Source/WebCore/inspector/InspectorWebGLAgent.cpp:100
> +    ASSERT(!glContext.hasNoValue());

Put ASSERT_NOT_REACHED() in the if block below instead.

> Source/WebCore/inspector/InspectorWebGLAgent.cpp:105
> +    if (module.hasNoValue())

Put ASSERT_NOT_REACHED() in the if block below instead.
Comment 7 Andrey Adaikin 2012-06-21 08:47:50 PDT
Comment on attachment 148727 [details]
Rebased patch to land

View in context: https://bugs.webkit.org/attachment.cgi?id=148727&action=review

>> Source/WebCore/inspector/InjectedScriptWebGLModule.h:49
>> +    static InjectedScriptWebGLModule injectedModuleForState(InjectedScriptManager*, ScriptState*);
> 
> ensureModuleInjectedForState or simply moduleForState?

renamed to moduleForState

>> Source/WebCore/inspector/InspectorWebGLAgent.cpp:100
>> +    ASSERT(!glContext.hasNoValue());
> 
> Put ASSERT_NOT_REACHED() in the if block below instead.

Done.

>> Source/WebCore/inspector/InspectorWebGLAgent.cpp:105
>> +    if (module.hasNoValue())
> 
> Put ASSERT_NOT_REACHED() in the if block below instead.

Done.
Comment 8 Andrey Adaikin 2012-06-21 08:49:25 PDT
Created attachment 148813 [details]
Patch to land
Comment 9 WebKit Review Bot 2012-06-21 09:54:14 PDT
Comment on attachment 148813 [details]
Patch to land

Clearing flags on attachment: 148813

Committed r120929: <http://trac.webkit.org/changeset/120929>
Comment 10 WebKit Review Bot 2012-06-21 09:54:20 PDT
All reviewed patches have been landed.  Closing bug.