Summary: | Web Inspector: [WebGL] Add injected WebGL module class | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Adaikin <aandrey> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Adaikin <aandrey> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, rik, timothy, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 89530 | ||||||||||
Bug Blocks: | 88973 | ||||||||||
Attachments: |
|
Description
Andrey Adaikin
2012-06-20 12:12:35 PDT
Created attachment 148624 [details]
Patch
Comment on attachment 148624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148624&action=review > Source/WebCore/inspector/InjectedScriptWebGLModule.cpp:46 > + : InjectedScriptModule("InjectedScriptWebGLModule") "webgl"? Comment on attachment 148624 [details] Patch Rejecting attachment 148624 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: anager.h patching file Source/WebCore/inspector/InjectedScriptModule.cpp patching file Source/WebCore/inspector/InjectedScriptModule.h patching file Source/WebCore/inspector/InjectedScriptWebGLModule.cpp patching file Source/WebCore/inspector/InjectedScriptWebGLModule.h patching file Source/WebCore/inspector/InspectorWebGLAgent.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13012097 Created attachment 148727 [details]
Rebased patch to land
Comment on attachment 148624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148624&action=review >> Source/WebCore/inspector/InjectedScriptWebGLModule.cpp:46 >> + : InjectedScriptModule("InjectedScriptWebGLModule") > > "webgl"? For InjectedScript it was "InjectedScript". This string will be also passed into the InspectorInstrumentation::willCallFunction() method. Comment on attachment 148727 [details] Rebased patch to land View in context: https://bugs.webkit.org/attachment.cgi?id=148727&action=review > Source/WebCore/inspector/InjectedScriptWebGLModule.h:49 > + static InjectedScriptWebGLModule injectedModuleForState(InjectedScriptManager*, ScriptState*); ensureModuleInjectedForState or simply moduleForState? > Source/WebCore/inspector/InspectorWebGLAgent.cpp:100 > + ASSERT(!glContext.hasNoValue()); Put ASSERT_NOT_REACHED() in the if block below instead. > Source/WebCore/inspector/InspectorWebGLAgent.cpp:105 > + if (module.hasNoValue()) Put ASSERT_NOT_REACHED() in the if block below instead. Comment on attachment 148727 [details] Rebased patch to land View in context: https://bugs.webkit.org/attachment.cgi?id=148727&action=review >> Source/WebCore/inspector/InjectedScriptWebGLModule.h:49 >> + static InjectedScriptWebGLModule injectedModuleForState(InjectedScriptManager*, ScriptState*); > > ensureModuleInjectedForState or simply moduleForState? renamed to moduleForState >> Source/WebCore/inspector/InspectorWebGLAgent.cpp:100 >> + ASSERT(!glContext.hasNoValue()); > > Put ASSERT_NOT_REACHED() in the if block below instead. Done. >> Source/WebCore/inspector/InspectorWebGLAgent.cpp:105 >> + if (module.hasNoValue()) > > Put ASSERT_NOT_REACHED() in the if block below instead. Done. Created attachment 148813 [details]
Patch to land
Comment on attachment 148813 [details] Patch to land Clearing flags on attachment: 148813 Committed r120929: <http://trac.webkit.org/changeset/120929> All reviewed patches have been landed. Closing bug. |