Bug 89589

Summary: [Chromium] Damage tracker is not used without partial swap, causing valid render passes to be removed
Product: WebKit Reporter: zlieber
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89630, 89631    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zlieber 2012-06-20 11:40:16 PDT 
[Chromium] html5-demos.appspot.com/static/webaudio/createMediaSourceElement.html broken
Comment 1 zlieber 2012-06-20 12:35:08 PDT 
Created attachment 148629 [details]
Patch
Comment 2 Dana Jansens 2012-06-20 12:40:34 PDT 
Comment on attachment 148629 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148629&action=review

> Source/WebCore/ChangeLog:3
> +        [Chromium] html5-demos.appspot.com/static/webaudio/createMediaSourceElement.html broken

Can you name this after what the patch is doing?
Comment 3 zlieber 2012-06-20 13:26:09 PDT 
Created attachment 148643 [details]
Patch
Comment 4 Adrienne Walker 2012-06-20 13:27:21 PDT 
Comment on attachment 148643 [details]
Patch

R=me.  Thanks for the quick fix.
Comment 5 WebKit Review Bot 2012-06-20 14:22:21 PDT 
Comment on attachment 148643 [details]
Patch

Rejecting attachment 148643 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13010038
Comment 6 zlieber 2012-06-20 15:04:32 PDT 
Created attachment 148662 [details]
Patch
Comment 7 WebKit Review Bot 2012-06-20 17:43:25 PDT 
Comment on attachment 148662 [details]
Patch

Clearing flags on attachment: 148662

Committed r120889: <http://trac.webkit.org/changeset/120889>
Comment 8 WebKit Review Bot 2012-06-20 17:43:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2012-06-20 18:56:17 PDT 
Re-opened since this is blocked by 89630
Comment 10 Adrienne Walker 2012-06-20 22:26:47 PDT 
Comment on attachment 148662 [details]
Patch

Let's give this another CQ+.
Comment 11 WebKit Review Bot 2012-06-20 22:40:13 PDT 
Comment on attachment 148662 [details]
Patch

Clearing flags on attachment: 148662

Committed r120904: <http://trac.webkit.org/changeset/120904>
Comment 12 WebKit Review Bot 2012-06-20 22:40:17 PDT 
All reviewed patches have been landed.  Closing bug.