Bug 89588

Summary: tweak output of webkit-patch print-{baselines,expectations}
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing w/ more tests none

Dirk Pranke
Reported 2012-06-20 11:34:38 PDT
tweak output of webkit-patch print-{baselines,expectations}
Attachments
Patch (2.55 KB, patch)
2012-06-20 11:36 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
patch for landing w/ more tests (8.61 KB, patch)
2012-06-20 12:26 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-20 11:36:17 PDT
Created attachment 148613 [details] Patch
Dirk Pranke
Comment 2 2012-06-20 11:41:15 PDT
The patch just adds some blank lines in between each platform's results.
Tony Chang
Comment 3 2012-06-20 11:45:47 PDT
Comment on attachment 148613 [details] Patch We don't have a test for this?
Dirk Pranke
Comment 4 2012-06-20 12:26:01 PDT
Created attachment 148625 [details] patch for landing w/ more tests
Dirk Pranke
Comment 5 2012-06-20 12:27:50 PDT
(In reply to comment #3) > (From update of attachment 148613 [details]) > We don't have a test for this? There were tests, but they were only testing displaying the results for one port, so the change didn't affect it. I've added tests for displaying multiple ports, which resulted in finding some bugs and cleaning up some things, but it's all minor so I'm not gonna trouble you for another review.
Dirk Pranke
Comment 6 2012-06-20 12:47:39 PDT
Committed r120851: <http://trac.webkit.org/changeset/120851>
Note You need to log in before you can comment on or make changes to this bug.