Bug 89588 - tweak output of webkit-patch print-{baselines,expectations}
Summary: tweak output of webkit-patch print-{baselines,expectations}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 11:34 PDT by Dirk Pranke
Modified: 2012-06-20 12:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.55 KB, patch)
2012-06-20 11:36 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
patch for landing w/ more tests (8.61 KB, patch)
2012-06-20 12:26 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-06-20 11:34:38 PDT 
tweak output of webkit-patch print-{baselines,expectations}
Comment 1 Dirk Pranke 2012-06-20 11:36:17 PDT 
Created attachment 148613 [details]
Patch
Comment 2 Dirk Pranke 2012-06-20 11:41:15 PDT 
The patch just adds some blank lines in between each platform's results.
Comment 3 Tony Chang 2012-06-20 11:45:47 PDT 
Comment on attachment 148613 [details]
Patch

We don't have a test for this?
Comment 4 Dirk Pranke 2012-06-20 12:26:01 PDT 
Created attachment 148625 [details]
patch for landing w/ more tests
Comment 5 Dirk Pranke 2012-06-20 12:27:50 PDT 
(In reply to comment #3)
> (From update of attachment 148613 [details])
> We don't have a test for this?

There were tests, but they were only testing displaying the results for one port, so the change didn't affect it. I've added tests for displaying multiple ports, which resulted in finding some bugs and cleaning up some things, but it's all minor so I'm not gonna trouble you for another review.
Comment 6 Dirk Pranke 2012-06-20 12:47:39 PDT 
Committed r120851: <http://trac.webkit.org/changeset/120851>