Bug 89578

Summary:

[CSS Shaders] Rename CustomFilterShader class name to CustomFilterCompiledProgram

Product:

WebKit

Reporter:

Alexandru Chiculita <achicu>

Component:

Layout and Rendering

Assignee:

Alexandru Chiculita <achicu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch V1	none

Description Alexandru Chiculita 2012-06-20 10:01:17 PDT

We have two classes that have similar name:
1. CustomFilterProgram - base class of the StyleCustomFilterProgram class which keeps references to the CSS Shaders
2. CustomFilterShader - object created as a result of compiling a CustomFilterProgram.

I suppose that CustomFilterShader can be changed to CustomFilterCompiledProgram to better show the link to the CustomFilterProgram and the fact that it stores the precompiled shader.

Comment 1 Alexandru Chiculita 2012-06-20 16:58:04 PDT

Created attachment 148682 [details]
Patch V1

Comment 2 Dean Jackson 2012-06-20 17:05:40 PDT

Comment on attachment 148682 [details]
Patch V1

rs=me

Comment 3 WebKit Review Bot 2012-06-20 18:14:14 PDT

Comment on attachment 148682 [details]
Patch V1

Clearing flags on attachment: 148682

Committed r120893: <http://trac.webkit.org/changeset/120893>

Comment 4 WebKit Review Bot 2012-06-20 18:14:19 PDT

All reviewed patches have been landed.  Closing bug.