Bug 89559

Summary: Web Inspector: duplicating selected text when Enter key is pressed.
Product: WebKit Reporter: Sergey Rogulenko <rogulenko>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Sergey Rogulenko
Reported 2012-06-20 03:35:17 PDT
If you open a file in Sources in inspector, select some text from bottom to top(!) and press Enter key, the selected text will not substitute with one new line. Also, if you try to undo this action, the respond will not bring you to initial state.
Attachments
Patch (1.78 KB, patch)
2012-06-20 06:12 PDT, Sergey Rogulenko 		no flags
DetailsFormatted DiffDiff
Patch (1.31 KB, patch)
2012-06-20 07:48 PDT, Sergey Rogulenko 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergey Rogulenko
Comment 1 2012-06-20 06:12:25 PDT
Created attachment 148546 [details] Patch
Pavel Feldman
Comment 2 2012-06-20 06:55:55 PDT
Comment on attachment 148546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148546&action=review > Source/WebCore/ChangeLog:3 > + Fixing Bug 89559 - Web Inspector: handling enter key bug Patch should start with the bug title. > Source/WebCore/ChangeLog:5 > + Web Inspector: handling enter key bug This bug title is too vague, please be more specific > Source/WebCore/ChangeLog:12 > + The person who fixed Bug 71625 forgot to use result of his own method. We typically say "Regressed in rXXXX" where XXXX is a revision number. That should be mentioned in the bug description. > Source/WebCore/inspector/front-end/TextViewer.js:1254 > this._exitTextChangeMode(range, newRange); You should call exitTextChangeMode with exact newRange that editRange returned.
Sergey Rogulenko
Comment 3 2012-06-20 07:48:57 PDT
Created attachment 148566 [details] Patch
WebKit Review Bot
Comment 4 2012-06-20 09:15:39 PDT
Comment on attachment 148566 [details] Patch Clearing flags on attachment: 148566 Committed r120827: <http://trac.webkit.org/changeset/120827>
WebKit Review Bot
Comment 5 2012-06-20 09:15:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.