Summary: | Web Inspector: Move requestId allocation from FileSystem frontend to backend | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Taiju Tsuiki <tzik> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Taiju Tsuiki <tzik> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 68203, 73301, 87856 | ||||||||
Attachments: |
|
Description
Taiju Tsuiki
2012-06-20 02:31:46 PDT
Created attachment 148527 [details]
Patch
Comment on attachment 148527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148527&action=review Please fix a couple of nits before landing. > Source/WebCore/ChangeLog:10 > + Please remove extra blank line. > Source/WebCore/inspector/Inspector.json:1441 > + { "name": "requestId", "$ref": "FileSystem.RequestId", "description": "Request identifier. Corresponding fileSystemRootReceived event should have same requestId with this." } "$ref": "RequestId" is enough since you are inside FileSystem domain. > Source/WebCore/inspector/Inspector.json:1453 > + "description": "Returns content of the directory as didReadDirectory event." didReadDirectory ->directoryContentReceived > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:413 > + ASSERT(requestId); This is up to the protocol implementation to provide correct output parameter pointer, you should not check it here. > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:427 > + ASSERT(requestId); Ditto. Created attachment 148709 [details]
Patch
Comment on attachment 148527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148527&action=review Thanks, I updated the patch. >> Source/WebCore/ChangeLog:10 >> + > > Please remove extra blank line. Done >> Source/WebCore/inspector/Inspector.json:1441 >> + { "name": "requestId", "$ref": "FileSystem.RequestId", "description": "Request identifier. Corresponding fileSystemRootReceived event should have same requestId with this." } > > "$ref": "RequestId" is enough since you are inside FileSystem domain. Done >> Source/WebCore/inspector/Inspector.json:1453 >> + "description": "Returns content of the directory as didReadDirectory event." > > didReadDirectory ->directoryContentReceived Done >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:413 >> + ASSERT(requestId); > > This is up to the protocol implementation to provide correct output parameter pointer, you should not check it here. Removed >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:427 >> + ASSERT(requestId); > > Ditto. Removed Comment on attachment 148709 [details] Patch Clearing flags on attachment: 148709 Committed r120906: <http://trac.webkit.org/changeset/120906> All reviewed patches have been landed. Closing bug. |