Summary: | [V8] Fix issue where a callback got a null calling context | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Erik Arvidsson <arv> | ||||
Component: | New Bugs | Assignee: | Erik Arvidsson <arv> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, haraken, japhet, jochen, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Erik Arvidsson
2012-06-19 16:54:20 PDT
Created attachment 148459 [details]
Patch
See http://code.google.com/p/chromium/issues/detail?id=130462 for more details Comment on attachment 148459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148459&action=review The change looks OK. > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:309 > + return V8Proxy::throwTypeError(0, args.GetIsolate()); 0 will output "Type error". What error message does JSC throw? (We want to keep the error message consistent between JSC and V8.) (In reply to comment #3) > (From update of attachment 148459 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148459&action=review > > The change looks OK. > > > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:309 > > + return V8Proxy::throwTypeError(0, args.GetIsolate()); > > 0 will output "Type error". What error message does JSC throw? (We want to keep the error message consistent between JSC and V8.) Yup. I wanted to use 0 to match JSC. Comment on attachment 148459 [details]
Patch
Thanks for the clarification.
Comment on attachment 148459 [details] Patch Clearing flags on attachment: 148459 Committed r120783: <http://trac.webkit.org/changeset/120783> All reviewed patches have been landed. Closing bug. |