Bug 89532

Summary: [V8] Fix issue where a callback got a null calling context
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Erik Arvidsson 2012-06-19 16:54:20 PDT
[V8] Fix issue where a callback got a null calling context
Comment 1 Erik Arvidsson 2012-06-19 16:56:04 PDT
Created attachment 148459 [details]
Patch
Comment 2 Erik Arvidsson 2012-06-19 16:57:18 PDT
See http://code.google.com/p/chromium/issues/detail?id=130462 for more details
Comment 3 Kentaro Hara 2012-06-19 17:06:52 PDT
Comment on attachment 148459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148459&action=review

The change looks OK.

> Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:309
> +        return V8Proxy::throwTypeError(0, args.GetIsolate());

0 will output "Type error". What error message does JSC throw? (We want to keep the error message consistent between JSC and V8.)
Comment 4 Erik Arvidsson 2012-06-19 17:30:08 PDT
(In reply to comment #3)
> (From update of attachment 148459 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148459&action=review
> 
> The change looks OK.
> 
> > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:309
> > +        return V8Proxy::throwTypeError(0, args.GetIsolate());
> 
> 0 will output "Type error". What error message does JSC throw? (We want to keep the error message consistent between JSC and V8.)

Yup. I wanted to use 0 to match JSC.
Comment 5 Kentaro Hara 2012-06-19 17:30:45 PDT
Comment on attachment 148459 [details]
Patch

Thanks for the clarification.
Comment 6 WebKit Review Bot 2012-06-19 18:04:16 PDT
Comment on attachment 148459 [details]
Patch

Clearing flags on attachment: 148459

Committed r120783: <http://trac.webkit.org/changeset/120783>
Comment 7 WebKit Review Bot 2012-06-19 18:04:20 PDT
All reviewed patches have been landed.  Closing bug.