Bug 89501

Summary: [GTK] Remove Windows support from plugins/gtk/
Product: WebKit Reporter: Kalev Lember <kalevlember>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 54531    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms
none
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms none

Kalev Lember
Reported 2012-06-19 12:55:55 PDT
The GTK+ port now uses plugins/gtk/ on Windows, which leaves PluginPackageGtk.cpp and PluginViewGtk.cpp solely for XP_UNIX platforms.
Attachments
Patch (14.50 KB, patch)
2012-06-19 12:58 PDT, Kalev Lember 		no flags
DetailsFormatted DiffDiff
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms (3.75 KB, patch)
2012-06-21 14:00 PDT, Kalev Lember 		no flags
DetailsFormatted DiffDiff
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms (2.61 KB, patch)
2012-06-21 15:01 PDT, Kalev Lember 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kalev Lember
Comment 1 2012-06-19 12:58:00 PDT
Created attachment 148396 [details] Patch
Martin Robinson
Comment 2 2012-06-21 11:21:22 PDT
Comment on attachment 148396 [details] Patch Perhaps it makes sense for non-XP_UNIX and non-Windows platforms to use the empty plugin support while/before we do this?
Kalev Lember
Comment 3 2012-06-21 11:47:54 PDT
I think that would make sense. I'll put together a patch that switches other platforms to PluginPackageNone.cpp + PluginViewNone.cpp. For Mac, I think it would make sense to eventually switch to PluginPackageMac.cpp + PluginViewMac.mm, but I'm not particularly interested in Mac right now. Although from the look of it, I doubt anyone has built webkitgtk for non-X11 and non-win32 in a long time. For instance, the build files include WidgetBackingStoreCairo.cpp for Windows, and GtkWidgetBackingStoreX11.cpp for X11, and no backing store at all for other platforms. This surely can't build at all.
Kalev Lember
Comment 4 2012-06-21 14:00:22 PDT
Created attachment 148882 [details] [GTK] Use the empty plugin support on non-X11 and non-Windows platforms
Martin Robinson
Comment 5 2012-06-21 14:23:35 PDT
Comment on attachment 148882 [details] [GTK] Use the empty plugin support on non-X11 and non-Windows platforms View in context: https://bugs.webkit.org/attachment.cgi?id=148882&action=review > Source/WebCore/GNUmakefile.list.am:4834 > +# ---- > +# NPAPI plugin support > +# ---- > +if TARGET_X11 There's no need to separate out plugin related files into their own lists. I think it's better just to organize everything by platform:
Kalev Lember
Comment 6 2012-06-21 15:01:02 PDT
Created attachment 148893 [details] [GTK] Use the empty plugin support on non-X11 and non-Windows platforms Fair enough, updated the patch to go back to per-platform file lists.
Martin Robinson
Comment 7 2012-06-21 15:02:13 PDT
Comment on attachment 148893 [details] [GTK] Use the empty plugin support on non-X11 and non-Windows platforms Thanks!
WebKit Review Bot
Comment 8 2012-06-21 19:05:42 PDT
Comment on attachment 148893 [details] [GTK] Use the empty plugin support on non-X11 and non-Windows platforms Clearing flags on attachment: 148893 Committed r120993: <http://trac.webkit.org/changeset/120993>
Martin Robinson
Comment 9 2012-06-28 10:25:05 PDT
Comment on attachment 148396 [details] Patch Great!
WebKit Review Bot
Comment 10 2012-06-28 11:15:33 PDT
Comment on attachment 148396 [details] Patch Clearing flags on attachment: 148396 Committed r121445: <http://trac.webkit.org/changeset/121445>
WebKit Review Bot
Comment 11 2012-06-28 11:15:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.