| Summary: | [GTK] Remove Windows support from plugins/gtk/ | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kalev Lember <kalevlember> | ||||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | mrobinson, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 54531 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Kalev Lember
2012-06-19 12:55:55 PDT
Created attachment 148396 [details]
Patch
Comment on attachment 148396 [details]
Patch
Perhaps it makes sense for non-XP_UNIX and non-Windows platforms to use the empty plugin support while/before we do this?
I think that would make sense. I'll put together a patch that switches other platforms to PluginPackageNone.cpp + PluginViewNone.cpp. For Mac, I think it would make sense to eventually switch to PluginPackageMac.cpp + PluginViewMac.mm, but I'm not particularly interested in Mac right now. Although from the look of it, I doubt anyone has built webkitgtk for non-X11 and non-win32 in a long time. For instance, the build files include WidgetBackingStoreCairo.cpp for Windows, and GtkWidgetBackingStoreX11.cpp for X11, and no backing store at all for other platforms. This surely can't build at all. Created attachment 148882 [details]
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms
Comment on attachment 148882 [details] [GTK] Use the empty plugin support on non-X11 and non-Windows platforms View in context: https://bugs.webkit.org/attachment.cgi?id=148882&action=review > Source/WebCore/GNUmakefile.list.am:4834 > +# ---- > +# NPAPI plugin support > +# ---- > +if TARGET_X11 There's no need to separate out plugin related files into their own lists. I think it's better just to organize everything by platform: Created attachment 148893 [details]
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms
Fair enough, updated the patch to go back to per-platform file lists.
Comment on attachment 148893 [details]
[GTK] Use the empty plugin support on non-X11 and non-Windows platforms
Thanks!
Comment on attachment 148893 [details] [GTK] Use the empty plugin support on non-X11 and non-Windows platforms Clearing flags on attachment: 148893 Committed r120993: <http://trac.webkit.org/changeset/120993> Comment on attachment 148396 [details]
Patch
Great!
Comment on attachment 148396 [details] Patch Clearing flags on attachment: 148396 Committed r121445: <http://trac.webkit.org/changeset/121445> All reviewed patches have been landed. Closing bug. |