Bug 89500

Summary: [BlackBerry] Should check the return value of fromUTF8() before executing it.
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
none
again
none
Another try
rwlbuis: review+
to commit
webkit.review.bot: commit-queue-
Changelog again! none

Yong Li
Reported 2012-06-19 12:53:13 PDT
WebPagePrivate::executeJavaScript() should check the return value of fromUTF8() before executing it to avoid potential crash.
Attachments
the patch (1.73 KB, patch)
2012-06-19 12:58 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
again (1.91 KB, patch)
2012-06-19 13:02 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Another try (1.94 KB, patch)
2012-06-19 13:40 PDT, Yong Li 		rwlbuis: review+
DetailsFormatted DiffDiff
to commit (1.95 KB, patch)
2012-06-19 13:49 PDT, Yong Li 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Changelog again! (1.98 KB, patch)
2012-06-19 15:05 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-06-19 12:58:17 PDT
Created attachment 148397 [details] the patch
Yong Li
Comment 2 2012-06-19 13:02:53 PDT
Created attachment 148398 [details] again
Yong Li
Comment 3 2012-06-19 13:40:16 PDT
Created attachment 148408 [details] Another try
Rob Buis
Comment 4 2012-06-19 13:46:10 PDT
Comment on attachment 148408 [details] Another try View in context: https://bugs.webkit.org/attachment.cgi?id=148408&action=review LGTM. > Source/WebKit/blackberry/ChangeLog:9 > + before executing the script to avoid potential crash on invalid script source. Probably needs PR mention.
Yong Li
Comment 5 2012-06-19 13:49:08 PDT
Created attachment 148411 [details] to commit
WebKit Review Bot
Comment 6 2012-06-19 14:46:25 PDT
Comment on attachment 148411 [details] to commit Rejecting attachment 148411 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ipts/svn-apply', u'--force']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 succeeded at 703 (offset 2 lines). patching file Source/WebKit/blackberry/ChangeLog patch: **** malformed patch at line 22: [Blackberry] add a new Api named setAllowNotification Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12982521
Yong Li
Comment 7 2012-06-19 15:05:40 PDT
Created attachment 148437 [details] Changelog again!
WebKit Review Bot
Comment 8 2012-06-19 16:50:47 PDT
Comment on attachment 148437 [details] Changelog again! Clearing flags on attachment: 148437 Committed r120774: <http://trac.webkit.org/changeset/120774>
Note You need to log in before you can comment on or make changes to this bug.