Bug 89479

Summary: Assertion for event's target is wrong.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: UI EventsAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89073    
Attachments:
Description Flags
fix an assertion
none
Patch for landing
none
Patch for landing none

Hayato Ito
Reported 2012-06-19 09:34:06 PDT
An assertion used in EventContext's constructor is wrong. ASSERT(!m_target || m_target->toNode() || accessible(m_target->toNode())); '!' is missing. That should be: ASSERT(!m_target || !m_target->toNode() || accessible(m_target->toNode()));
Attachments
fix an assertion (2.90 KB, patch)
2012-06-19 09:55 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.93 KB, patch)
2012-06-19 22:30 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.93 KB, patch)
2012-06-19 22:51 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-06-19 09:55:32 PDT
Created attachment 148351 [details] fix an assertion
Hayato Ito
Comment 2 2012-06-19 22:30:56 PDT
Created attachment 148504 [details] Patch for landing
WebKit Review Bot
Comment 3 2012-06-19 22:40:15 PDT
Comment on attachment 148504 [details] Patch for landing Rejecting attachment 148504 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 MORITA Hajime found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12995131
Hayato Ito
Comment 4 2012-06-19 22:51:55 PDT
Created attachment 148510 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-06-19 23:30:20 PDT
Comment on attachment 148510 [details] Patch for landing Clearing flags on attachment: 148510 Committed r120806: <http://trac.webkit.org/changeset/120806>
WebKit Review Bot
Comment 6 2012-06-19 23:30:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.