Bug 89476

Summary: Web Inspector: mark used/allocated JS heap on the native memory bar chart.
Product: WebKit Reporter: Alexei Filippov <alph>
Component: Web Inspector (Deprecated)Assignee: Alexei Filippov <alph>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Alexei Filippov
Reported 2012-06-19 08:40:28 PDT
EOM
Attachments
Patch (4.44 KB, patch)
2012-06-19 08:45 PDT, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (5.13 KB, patch)
2012-06-20 08:18 PDT, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexei Filippov
Comment 1 2012-06-19 08:45:15 PDT
Created attachment 148345 [details] Patch
Yury Semikhatsky
Comment 2 2012-06-19 23:53:39 PDT
Comment on attachment 148345 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148345&action=review > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:382 > + this._unused = {}; Should we use one map name -> structure describing barDiv instead? > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:473 > + var subChildrenSize = 0; usedSize?
Alexei Filippov
Comment 3 2012-06-20 08:18:00 PDT
Created attachment 148572 [details] Patch
WebKit Review Bot
Comment 4 2012-06-20 09:33:42 PDT
Comment on attachment 148572 [details] Patch Clearing flags on attachment: 148572 Committed r120829: <http://trac.webkit.org/changeset/120829>
WebKit Review Bot
Comment 5 2012-06-20 09:33:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.