| Summary: | Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hans Wennborg <hans> | ||||||
| Component: | New Bugs | Assignee: | Hans Wennborg <hans> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, eric, fishd, jamesr, ojan, primiano, satish, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 80261 | ||||||||
| Attachments: |
|
||||||||
|
Description
Hans Wennborg
2012-06-19 04:27:32 PDT
Created attachment 148311 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. I assume there is a spec underway somewhere? A quick google search didn't find anything about this API. Thank you. :) I would encourage you to include that link (or a similar perma-link) in your ChangeLog for future patches/bugs. Just makes it easier for others to follow-along at home. No need to update this patch of course. Comment on attachment 148311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148311&action=review > LayoutTests/fast/speech/scripted/basics-expected.txt:14 > +PASS 'maxNBest' in speechReco is true Do you want to be checking true here or for a specific number? (In reply to comment #5) > Thank you. :) I would encourage you to include that link (or a similar perma-link) in your ChangeLog for future patches/bugs. Just makes it easier for others to follow-along at home. No need to update this patch of course. Will do. (In reply to comment #6) > (From update of attachment 148311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148311&action=review > > > LayoutTests/fast/speech/scripted/basics-expected.txt:14 > > +PASS 'maxNBest' in speechReco is true > > Do you want to be checking true here or for a specific number? Ah, yes we should check the default value. Will fix. This was renamed to maxAlternatives in the spec. New patch coming up. Created attachment 148533 [details]
Patch
Comment on attachment 148533 [details]
Patch
OK.
Comment on attachment 148533 [details] Patch Clearing flags on attachment: 148533 Committed r120817: <http://trac.webkit.org/changeset/120817> All reviewed patches have been landed. Closing bug. |