Bug 89457

Summary: [chromium] Remove duplicate mock CCLayerTreeHostClient
Product: WebKit Reporter: Sami Kyöstilä <skyostil>
Component: New BugsAssignee: Sami Kyöstilä <skyostil>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Sami Kyöstilä
Reported 2012-06-19 04:06:42 PDT
[chromium] Remove duplicate mock CCLayerTreeHostClient
Attachments
Patch (2.94 KB, patch)
2012-06-19 04:07 PDT, Sami Kyöstilä 		no flags
DetailsFormatted DiffDiff
Patch (2.92 KB, patch)
2012-07-19 02:26 PDT, Sami Kyöstilä 		no flags
DetailsFormatted DiffDiff
Patch (2.92 KB, patch)
2012-07-19 05:57 PDT, Sami Kyöstilä 		no flags
DetailsFormatted DiffDiff
Patch (2.92 KB, patch)
2012-07-19 06:06 PDT, Sami Kyöstilä 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sami Kyöstilä
Comment 1 2012-06-19 04:07:44 PDT
Created attachment 148309 [details] Patch
Adrienne Walker
Comment 2 2012-07-18 14:51:48 PDT
Comment on attachment 148309 [details] Patch Belated R=me. Nobody got CC'd on this bug, which is why it languished.
WebKit Review Bot
Comment 3 2012-07-18 15:07:51 PDT
Comment on attachment 148309 [details] Patch Rejecting attachment 148309 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp Hunk #1 FAILED at 28. Hunk #2 FAILED at 59. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adrienne W..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13273645
Sami Kyöstilä
Comment 4 2012-07-19 02:25:40 PDT
Thanks Enne! My bad for failing to CC anyone. Rebased patch coming up.
Sami Kyöstilä
Comment 5 2012-07-19 02:26:44 PDT
Created attachment 153212 [details] Patch - Rebased.
Sami Kyöstilä
Comment 6 2012-07-19 05:57:54 PDT
Created attachment 153240 [details] Patch - Marking as reviewed.
Sami Kyöstilä
Comment 7 2012-07-19 06:06:00 PDT
Created attachment 153242 [details] Patch
Peter Beverloo
Comment 8 2012-07-19 06:06:28 PDT
Comment on attachment 153242 [details] Patch Setting cq+ on request.
WebKit Review Bot
Comment 9 2012-07-19 07:44:30 PDT
Comment on attachment 153242 [details] Patch Clearing flags on attachment: 153242 Committed r123101: <http://trac.webkit.org/changeset/123101>
WebKit Review Bot
Comment 10 2012-07-19 07:44:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.