Bug 89449

Summary: [Qt] Buildfix for newer Qt5
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: abecsi, cmarcelo, hausmann, menard, ossy, webkit.review.bot, zoltan
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2012-06-19 02:38:28 PDT
After ee7fa67eb0060b9c794bae4c7b06110c3b9626e0 in qtbase, QWeakPointer is deprecated, we should use QPointer instead of QWeakPointer. Patch is coming soon.
Attachments
Patch (8.62 KB, patch)
2012-06-19 02:45 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (10.17 KB, patch)
2012-06-19 03:56 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-19 02:45:59 PDT
Created attachment 148296 [details] Patch
Simon Hausmann
Comment 2 2012-06-19 03:01:12 PDT
Comment on attachment 148296 [details] Patch r=me. this is safe to land even before the update.
Early Warning System Bot
Comment 3 2012-06-19 03:24:30 PDT
Comment on attachment 148296 [details] Patch Attachment 148296 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12973661
Csaba Osztrogonác
Comment 4 2012-06-19 03:26:39 PDT
Comment on attachment 148296 [details] Patch We need ifdef guards for Qt 4.8 build. :-/
Simon Hausmann
Comment 5 2012-06-19 03:32:27 PDT
(In reply to comment #4) > (From update of attachment 148296 [details]) > We need ifdef guards for Qt 4.8 build. :-/ I think it would be easier to change the calls to clear() with a null pointer assignment, i.e. foopointer.clear(); with foopointer = 0; and thus avoid the #ifdefs.
Csaba Osztrogonác
Comment 6 2012-06-19 03:33:56 PDT
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 148296 [details] [details]) > > We need ifdef guards for Qt 4.8 build. :-/ > > I think it would be easier to change the calls to clear() with a null pointer assignment, i.e. > > foopointer.clear(); > > with > > foopointer = 0; > > and thus avoid the #ifdefs. let me check and fix it
Andras Becsi
Comment 7 2012-06-19 03:43:26 PDT
*** Bug 89029 has been marked as a duplicate of this bug. ***
Andras Becsi
Comment 8 2012-06-19 03:45:25 PDT
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (From update of attachment 148296 [details] [details] [details]) > > > We need ifdef guards for Qt 4.8 build. :-/ > > > > I think it would be easier to change the calls to clear() with a null pointer assignment, i.e. > > > > foopointer.clear(); > > > > with > > > > foopointer = 0; > > > > and thus avoid the #ifdefs. > > let me check and fix it I think there is a fix in qtbase for the clear() function in a newer hash, it just did not make it to the supermodule yet.
Csaba Osztrogonác
Comment 9 2012-06-19 03:49:40 PDT
(In reply to comment #8) > I think there is a fix in qtbase for the clear() function in a newer hash, it just did not make it to the supermodule yet. The latest Qt5 hash contains QPointer.clear(), but Qt 4.8's QPointer() doesn't.
Csaba Osztrogonác
Comment 10 2012-06-19 03:56:58 PDT
Created attachment 148308 [details] Patch Use zero assignment instead of QPointer.clear(), because Qt4's QPointer class doesn't have clear method.
Csaba Osztrogonác
Comment 11 2012-06-19 04:35:21 PDT
Comment on attachment 148308 [details] Patch Landed in http://trac.webkit.org/changeset/120704
Note You need to log in before you can comment on or make changes to this bug.