Bug 89430
| Summary: | [CSS Regions] CSS regions should be re-enabled on Windows | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Honeycutt <jhoneycutt> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | donggwan.kim, jhoneycutt, mibalan, rosca, WebkitBugTracker |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 57312 | ||
Jon Honeycutt
Enabling CSS regions (<http://trac.webkit.org/changeset/120280>) caused all Windows tests to crash:
<http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/24746> (120279)
<http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/24747> (120280)
The crash occurred when trying to write to the static bool value WebCore::RuntimeEnabledFeatures::isCSSExclusionsEnabled from WebCore::InternalSettings::restoreTo(). I believe that we are exporting this bool data member incorrectly.
r120280 was rolled out in <http://trac.webkit.org/changeset/120523>. It should be rolled back in when the crashing bug is fixed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mihai Balan
The crashes were fixed in #90435.
*** This bug has been marked as a duplicate of bug 90435 ***
Mihai Balan
*** Bug 82047 has been marked as a duplicate of this bug. ***