Summary: | [Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||||||
Component: | Forms | Assignee: | yosin | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 88970 | ||||||||||
Attachments: |
|
Description
yosin
2012-06-18 23:02:29 PDT
Created attachment 148261 [details]
Patch 1
Comment on attachment 148261 [details]
Patch 1
Could you review this patch?
Thanks in advance.
Comment on attachment 148261 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=148261&action=review > Source/WebCore/html/HTMLInputElement.h:267 > + virtual bool isTextFormControlFocusable() const; > + virtual bool isTextFormControlKeyboardFocusable(KeyboardEvent*) const; > + virtual bool isTextFormControlMouseFocusable() const; They shouldn't be virtual. Also, please put them just below setValueInternal() because it is also a helper for *InputType. > Source/WebCore/html/RadioInputType.cpp:119 > + if (!element()->isTextFormControlKeyboardFocusable(event)) if (!InputType::isKeyboardFocusable(event)) is better. Created attachment 148270 [details]
Patch 2
Comment on attachment 148270 [details]
Patch 2
Could you review this patch?
Thanks in advance.
= Changes since last review ==
* Remove "virtual" from isTextFormControl*Focusable method declarations
** as suggested
* Call InputType::isKeyboardFocusable() in RadioInputType::isKeyboardFocusable
** as suggested
Comment on attachment 148270 [details] Patch 2 Attachment 148270 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12972717 Created attachment 148274 [details]
Patch 3
Comment on attachment 148274 [details]
Patch 3
Could you review this patch?
Thanks in advance.
= Changes since last review ==
* Remove "virtual" from isTextFormControl*Focusable method declarations
** as suggested
* Call InputType::isKeyboardFocusable() in RadioInputType::isKeyboardFocusable
** as suggested
* Remove unused prameter in TextFieldInputType::isKeyboardFocusable
** Failed on Mac build
Comment on attachment 148274 [details]
Patch 3
ok
Comment on attachment 148274 [details] Patch 3 Clearing flags on attachment: 148274 Committed r120695: <http://trac.webkit.org/changeset/120695> All reviewed patches have been landed. Closing bug. |