Bug 89423

Summary: [EFL] Support screenDepth() functionality.
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89964    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-06-18 22:52:17 PDT
Support screenDepth() based on ecore_x_window_depth_get(). This functionality may be used by both WebKit1 and WebKit2. So, concrete function is placed into EflScreenUtilities.cpp. This patch can't support existing test cases. Because, EFL DumpRenderTree works without X11 window by default. http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L69
Attachments
Patch (3.56 KB, patch)
2012-06-18 22:53 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2012-06-18 23:05 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2012-06-18 23:07 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.76 KB, patch)
2012-06-25 08:37 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.76 KB, patch)
2012-06-25 09:22 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-06-18 22:53:57 PDT
Created attachment 148250 [details] Patch
Gyuyoung Kim
Comment 2 2012-06-18 23:05:20 PDT
Created attachment 148253 [details] Patch
Gyuyoung Kim
Comment 3 2012-06-18 23:07:44 PDT
Created attachment 148254 [details] Patch
Gyuyoung Kim
Comment 4 2012-06-19 22:15:48 PDT
CC'ing Antonio.
Kenneth Rohde Christiansen
Comment 5 2012-06-24 19:15:42 PDT
Comment on attachment 148254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148254&action=review > Source/WebCore/platform/efl/EflScreenUtilities.cpp:139 > + if (!window) > + return 0; Is that a good value? depth of 0 ? Why not just return 8 like below?
Gyuyoung Kim
Comment 6 2012-06-25 08:37:35 PDT
Created attachment 149296 [details] Patch
Gyuyoung Kim
Comment 7 2012-06-25 09:22:36 PDT
Created attachment 149307 [details] Patch
Gyuyoung Kim
Comment 8 2012-06-25 09:23:33 PDT
(In reply to comment #5) > (From update of attachment 148254 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148254&action=review > > > Source/WebCore/platform/efl/EflScreenUtilities.cpp:139 > > + if (!window) > > + return 0; > > Is that a good value? depth of 0 ? Why not just return 8 like below? Yes, I fix it. Thanks.
WebKit Review Bot
Comment 9 2012-06-25 10:14:59 PDT
Comment on attachment 149307 [details] Patch Clearing flags on attachment: 149307 Committed r121163: <http://trac.webkit.org/changeset/121163>
WebKit Review Bot
Comment 10 2012-06-25 10:15:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.