Summary: | Web Inspector: Unify FileSystem callbacks. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Taiju Tsuiki <tzik> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Taiju Tsuiki <tzik> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 88602 | ||||||||||
Bug Blocks: | 68203, 87856, 89642 | ||||||||||
Attachments: |
|
Description
Taiju Tsuiki
2012-06-18 22:07:03 PDT
Created attachment 148246 [details]
Patch
Comment on attachment 148246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148246&action=review > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:181 > + RefPtr<EntryCallback> successCallback = createCallbackDispatcher(TypeParam<EntryCallback>(), this, &GetFileSystemRootTask::gotEntry); I think you can remove TypaParam argument and do createCallbackDispatcher<EntryCallback>(this, &GetFileSystemRootTask::gotEntry); instead. Created attachment 148762 [details]
Patch
Comment on attachment 148246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148246&action=review >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:181 >> + RefPtr<EntryCallback> successCallback = createCallbackDispatcher(TypeParam<EntryCallback>(), this, &GetFileSystemRootTask::gotEntry); > > I think you can remove TypaParam argument and do > createCallbackDispatcher<EntryCallback>(this, &GetFileSystemRootTask::gotEntry); > instead. We can't pass template parameter partially. Another option is like that: CallbackDispatcher<EntryCallback>::create(...). Is it acceptable? Created attachment 148789 [details]
Patch
Comment on attachment 148789 [details] Patch Clearing flags on attachment: 148789 Committed r120926: <http://trac.webkit.org/changeset/120926> All reviewed patches have been landed. Closing bug. |